Page MenuHomePhabricator

ipblocks query from EditPage unconditionally goes to master
Closed, ResolvedPublic

Description

While it's important that IP blocks on page save are fetched from the master DB (c.f. T43702), it would be nice if IP blocks on edit page views were fetched from the slave. This was the scheme I suggested in the context of T3138, and it was briefly implemented, but the optimisation was later accidentally lost during refactoring.

Current profiling indicates that this query is about 10% of wall clock time spent doing master queries, possibly plus connection overhead if this is the only master query being done on edit.


Version: 1.22.0
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:07 AM
bzimport set Reference to bz49419.
gerritbot added a subscriber: gerritbot.

Change 185095 had a related patch set uploaded (by Aaron Schulz):
Made EditPage avoid querying the master block table on form view

https://gerrit.wikimedia.org/r/185095

Patch-For-Review

Change 185095 merged by jenkins-bot:
Made EditPage avoid querying the master block table on form view

https://gerrit.wikimedia.org/r/185095