Page MenuHomePhabricator

New deployment of Parsoid leads to HTML insertion - needs deployed code reversion
Closed, ResolvedPublic


I have edited the page w:cs:Banolo Blahnik and after saving HTML code was left at the page. See this revision:

Version: unspecified
Severity: critical



Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:49 AM
bzimport set Reference to bz49577.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 49573 has been marked as a duplicate of this bug. ***

This is occurring fairly widely and I have a lot of reports. Moving it up to highest priority (because frankly something being broken that is already deployed > anything we might /want/ deployed).

Yes, first time I tried the new VisualEditor. My user page is live and I still left the HTML as an example. Tried a few more times to blank page with VE, it is real ugly. HTML leaks on HTML leaks on HTML leaks with each new save,

(In reply to comment #3)

Issue started ~ 11:37 UTC today per

If that's really accurate *maybe* this has some relevance (posting here in case someone who knows more can do something with it):

Jun 14 11:34:59 cerium puppet-agent[22506]: (/Stage[main]/Role::Cache::Parsoid/Varnish::Instance[parsoid-frontend]/Exec[load-new-vcl-file-frontend]) Triggered 'refresh' from 2 events
Jun 14 11:34:59 cerium puppet-agent[22506]: (/Stage[main]/Role::Cache::Parsoid/Varnish::Instance[parsoid-backend]/Exec[load-new-vcl-file]) Triggered 'refresh' from 2 events

A note; I've just spoken to James F; a fix to this is highest-priority. I'm deeply sorry about this (and think I speak for James and the VE team on that front, too).

Related URL: (Gerrit Change I267c8ba13a6ec1444010ce996fba05dfcba460fa)

Related URL: (Gerrit Change I267c8ba13a6ec1444010ce996fba05dfcba460fa)

Also note; as you can see from the gerrit change above, it looks like Ariel and James will be temporarily disabling the VE until this is solved for. I'm going to go round and notify people now :)

ignatus31oct wrote:

(One more example from En-wiki) See this edit (if your traffic is easy, the diff is half-Mb):

I only wanted to change one section, but after pressing a link everything was opened in VE. Well, I added text to different sections. There were no trouble with it, except that when I tried to type text into ''()'' italicised parentheses leaved by previous editor, when I pushed [BackSpace] at end (wrongly started to type in Cyrillic rather than Latin), first ( was doubled.

When I entered enough and pushed "Save", I was introduced to type in the desc, and to view changes or to save page. I've just read the digest of how good is the VE now and pushed "Save page", but after a time I've seen.........

It looks like an update to the libraries Parsoid depends on might have caused this issue. It would have been visible in the diff, but since the user is not seeing that by default any more few noticed.

Parsoid is rolled back, so this issue should be fixed.

To update, this bug was in an overly-keen Operations cacheing server configuration change which broke the caches' responses completely (and corrupted every response to not be what we want).

Sorry everyone for the disruption; we've now found (and killed) this problem, and re-enabled VisualEditor as before.

It's not, this bug had different symptoms, and that edit doesn't even seem to have been made using VE.

Ah, sorry, I missed the tag. I think you should; this is certainly something different than what was happening here.

Did you open a new bug? If so could you please link it? I have someone with a similar issue.

  • Bug 50049 has been marked as a duplicate of this bug. ***