Page MenuHomePhabricator
Create Task
Maniphest T51985

VisualEditor: Adjacent link annotations (one of which is from Parsoid, one from VisualEditor) should conjoin
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Insert the cursor immediately after the first letter of a link
  2. Hit delete/backspace
  3. Type a new character
  4. The new character isn't part of the link, so select the entire word and click the link button
  5. Re-enter the link article
  6. Save your changes

Expected result:
If you started with "[[Porcupine]]", you should end up with "[[porcupine]]".

Actual result:
If you started with "[[Porcupine]]", you end up with "[[porcupine|p]][[Porcupine|orcupine]]".

This is just a common use case demonstrating a more general bug. Namely, if you create a new link that subsumes an existing link, the existing link is preserved within the new link instead of being replaced.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50098

Details

Reference
bz49985

Event Timeline

• bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:50 AM
• bzimport added projects: VE-deploy-2013-07-04, VisualEditor-EditingTools.
• bzimport set Reference to bz49985.
kaldari created this task.Jun 21 2013, 10:55 PM
Jdforrester-WMF added a comment.Jun 21 2013, 10:56 PM

Ed, is this due to the DM stuff around adjacent annotations?

Esanders added a comment.Jun 23 2013, 10:07 AM

Similar but different. This case should definitely be fixed in VE, not Parsoid.

• Catrope added a comment.Jun 24 2013, 1:10 AM

There are two issues here.

First off, we should change getComparableObject() for MWInternalLinkAnnotation to normalize the title and possibly tweak other things to the point where links to the same title are comparable, even if they have different capitalizations or space-vs-underscore variants of that title. That will be both more semantically correct and serve as a workaround for this bug.

Secondly, because we want to stop merging comparable but different annotations in the converter, we need Parsoid to correctly process at least things like <a href="Porcupine">p</a><a href="Porcupine">orcupine</a> (adjacent <a>s with the same href) and possibly <a href="porcupine">p</a><a href="Porcupine">orcupine</a> as well (adjacent <a>s with different hrefs that normalize to the same title).

gerritbot added a comment.Jun 26 2013, 1:59 PM

Related URL: https://gerrit.wikimedia.org/r/70633 (Gerrit Change I5fb5bfc69c344ca4ce4803d7b6116074648a8d7e)

gerritbot added a comment.Jun 27 2013, 5:30 PM

Change 70633 merged by jenkins-bot:
Fix comparison of MW internal links

https://gerrit.wikimedia.org/r/70633

Jdforrester-WMF added a comment.Jun 27 2013, 5:45 PM

(In reply to comment #5)

Change 70633 merged by jenkins-bot:
Fix comparison of MW internal links

https://gerrit.wikimedia.org/r/70633

And with that change, this bug is fixed; closing. It will be deployed this afternoon.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits