Page MenuHomePhabricator

VisualEditor: Opening "Edit" tab (and section edit links) with a middle-click / Ctrl-click / Shift-click (new tab/window) disabled somehow
Closed, ResolvedPublic


This doesn't work; not quite sure why/how. Should be fixed.

Version: unspecified
Severity: major



Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:50 AM
bzimport set Reference to bz49993.

Some back-of-the-envelope work by users indicates that firefox (logged in) and chromium (logged out) on linux have this problem; firefox and IE on Windows (not logged in) do not.

pinkampersand.wikimedia wrote:

I should note that I've been having this bug (well, with ctrl-click on my laptop, but think that's the same thing), and I don't have VE enabled. However, this bug's several days old, and I'm pretty sure this has only been happening to me within the past hour. Chrome on a ChromeOS netbook.

  • Bug 50221 has been marked as a duplicate of this bug. ***

Raising importance, this is quite annoying. It's just been reported on [[WP:VPT]] for the second time today.

Fixed in gerrit 70735 which is now merged and will get pushed later today.

Related URL: (Gerrit Change I5245ab19ae16b79d2c562c05b94649a58e04a4fd)

I'm not sure how the fix was implemented, but it seems to have started occurring again - this time only in namespaces in which the VE isn't active.

My testing shows that ctrl+click works only in VE-enabled namespaces but middle click works everywhere in Firefox 22.

In Konqueror 4.8.5 (which is apparently not enabled for VE) both ctrl+click and middle click both work only in VE-enabled namespaces.

Gah, bad breakage related to making VE more lightweight - sorry about that. Gerrit 72069 fixes this, according to my local testing - we'll try to get this out today.

Change 72069 had a related patch set uploaded by Jforrester:
mw.ViewPageTarget.init: Move edit section to top init.

Change 72069 merged by jenkins-bot:
mw.ViewPageTarget.init: Move edit section to top init

Fix merged and will hopefully go out soon.