Page MenuHomePhabricator

VisualEditor: "Invalid token" message after period of inactivity leads to lost work
Closed, ResolvedPublic

Description

An attempt to save an article in the visual editor after a period of inactivity results in the "Invalid token" error message and saving fails. At this point, the user is completely stuck and their entire work is lost.

Loss of session data can also occur in the regular source code edit window, but is easily rectified by repeated saving; this doesn't work in the visual editor.

I would classify this as user-hostile behavior.


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50402

Details

Reference
bz50424

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:50 AM
bzimport set Reference to bz50424.

Change 73189 had a related patch set uploaded by Krinkle:
API: Split save action into separate API module

https://gerrit.wikimedia.org/r/73189

Change 73203 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Improve error message for badtoken error

https://gerrit.wikimedia.org/r/73203

Change 73189 merged by jenkins-bot:
api: Split save action into separate API module

https://gerrit.wikimedia.org/r/73189

Change 73203 merged by jenkins-bot:
mw.ViewPageTarget: Improve error message for badtoken error

https://gerrit.wikimedia.org/r/73203

Change 73446 had a related patch set uploaded by Krinkle:
(DRAFT) mw.ViewPageTarget: Refetch token if session expired

https://gerrit.wikimedia.org/r/73446

  • Bug 51302 has been marked as a duplicate of this bug. ***

I just encountered this problem. I would call this bug a blocker as it is effectively 'dataloss' in bmo keyword terminology!

Please note that the reporter of Bug 51302 also points out that the session expiry clock already starts ticking once an article is opened for *reading*, i.e. potentially much earlier than when the visual editor is started on the article.

Change 73446 merged by jenkins-bot:
mw.ViewPageTarget: Refetch token if session expired

https://gerrit.wikimedia.org/r/73446

This is now fixed in master, which will be deployed within the hour.