Page MenuHomePhabricator

{{PLURAL}} not working in 'mobile-frontend-diffview-editcount' message
Closed, ResolvedPublic

Description

The message 'mobile-frontend-diffview-editcount' contains a {{PLURAL:$1}}, but $1 is something like '<div>19,247</div>', so {{PLURAL}} returns always singular (see https://fr.m.wikipedia.org/wiki/Special:MobileDiff/94625388 for example).

Please add a second parameter which is the only number, non-formated.


Version: unspecified
Severity: normal

Details

Reference
bz50571

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:01 AM
bzimport set Reference to bz50571.
Ltrlg created this task.Jul 2 2013, 10:57 AM

Change 71630 had a related patch set uploaded by Jdlrobson:
Bug 50571: Make plural work for mobile-frontend-diffview-editcount

https://gerrit.wikimedia.org/r/71630

Change 71630 merged by jenkins-bot:
Bug 50571: Make plural work for mobile-frontend-diffview-editcount

https://gerrit.wikimedia.org/r/71630

Ltrlg added a comment.Jul 2 2013, 5:23 PM

As I can see in this patch, the number is still formated.

But {{PLURAL:1,000|sg|pl}} returns 'sg', so 'mobile-frontend-diffview-editcount' will still be incorrectly displayed.

This is the reason why I suggested to add a second parameter

Ltrlg added a comment.Jul 2 2013, 5:28 PM

Sorry, I verified : {{PLURAL:1,000|sg|pl}} returns 'pl' on an English wiki, I was testing on a French one.

*Confused* do I need to add a second parameter?
I tried to use one but it seemed to have no effect.
For me plural works with this patchset - but I've only tested on English - are you saying it doesn't?

Ltrlg added a comment.Jul 2 2013, 10:37 PM

It’s working, the tests I did was incorrect.