Page MenuHomePhabricator

Nearby broken on desktop - Uncaught TypeError: Cannot set property 'ontouchstart' of undefined
Closed, ResolvedPublic

Description

Screenshot

When I was opening the page
https://pt.wikipedia.org/wiki/Especial:Nearby
I got the following error on Google Chrome (28.0.1500.71)'s console:

Uncaught TypeError: Cannot set property 'ontouchstart' of undefined

init https://bits.wikimedia.org/pt.wikipedia.org/load.php?debug=false&lang=pt-br&modules=ext.centralNotice.bannerController%7Cext.dismissableSiteNotice%7Cext.uls.displaysettings%2Cime%2Cinit%2Cinputsettings%2Cinterface%2Clanguagenames%2Clanguagesettings%2Cpreferences%2Cwebfonts%7Cext.uls.webfonts.repository%7Cjquery.client%2Ccookie%2CdelayedBind%2Ci18n%2Cime%2CjStorage%2Cjson%2CmwExtension%2Ctipsy%2Culs%2Cwebfonts%7Cjquery.uls.data%2Cgrid%7Cmediawiki.Uri%2Capi%2Ccldr%2CjqueryMsg%2Clanguage%2Cnotify%2Cuser%2Cutil%7Cmediawiki.api.parse%7Cmediawiki.language.data%2Cinit%7Cmediawiki.legacy.ajax%2Cwikibits%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.startup%7Cmobile.head%2Cnearby%2Cstartup%7Cmobile.nearby.plumbing%2Cscripts%2Cstyles%7Cmobile.pagelist.styles%7Cmobile.stable.common%2Cplumbing%7Cmobile.toast.styles%7Cskins.vector.js%7Cwikibase.client.init&skin=vector&version=20130704T183545Z&*
fire https://bits.wikimedia.org/pt.wikipedia.org/load.php?debug=false&lang=pt-br&modules=ext.centralNotice.bannerController%7Cext.dismissableSiteNotice%7Cext.uls.displaysettings%2Cime%2Cinit%2Cinputsettings%2Cinterface%2Clanguagenames%2Clanguagesettings%2Cpreferences%2Cwebfonts%7Cext.uls.webfonts.repository%7Cjquery.client%2Ccookie%2CdelayedBind%2Ci18n%2Cime%2CjStorage%2Cjson%2CmwExtension%2Ctipsy%2Culs%2Cwebfonts%7Cjquery.uls.data%2Cgrid%7Cmediawiki.Uri%2Capi%2Ccldr%2CjqueryMsg%2Clanguage%2Cnotify%2Cuser%2Cutil%7Cmediawiki.api.parse%7Cmediawiki.language.data%2Cinit%7Cmediawiki.legacy.ajax%2Cwikibits%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.startup%7Cmobile.head%2Cnearby%2Cstartup%7Cmobile.nearby.plumbing%2Cscripts%2Cstyles%7Cmobile.pagelist.styles%7Cmobile.stable.common%2Cplumbing%7Cmobile.toast.styles%7Cskins.vector.js%7Cwikibase.client.init&skin=vector&version=20130704T183545Z&*
self.fireWith https://bits.wikimedia.org/pt.wikipedia.org/load.php?debug=false&lang=pt-br&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130620T163512Z
jQuery.extend.ready https://bits.wikimedia.org/pt.wikipedia.org/load.php?debug=false&lang=pt-br&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130620T163512Z
(anonymous function) https://bits.wikimedia.org/pt.wikipedia.org/load.php?debug=false&lang=pt-br&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130620T163512Z

The line of the error seems to be this:
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/e0c2cf2573a6603ea31dced342d2c2f4e70e571c/javascripts/common/mf-notification.js#L56


Version: unspecified
Severity: normal
URL: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/e0c2cf2573a6603ea31dced342d2c2f4e70e571c/javascripts/common/mf-notification.js#L56

Attached:

Details

Reference
bz50761

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:45 AM
bzimport set Reference to bz50761.
He7d3r created this task.Jul 4 2013, 6:49 PM

So this only effects desktop. A div is being appended to a non-existant element.

Easy fix, but I continue to worry about supporting nearby on desktop when our skin is so different...

  • Bug 50825 has been marked as a duplicate of this bug. ***

Change 72238 had a related patch set uploaded by Jdlrobson:
Fix nearby desktop view

https://gerrit.wikimedia.org/r/72238

Change 72238 merged by jenkins-bot:
Fix nearby desktop view

https://gerrit.wikimedia.org/r/72238

greg added a comment.Jul 8 2013, 6:17 PM

Accepting backport to WMF, do you need a LD before tomorrow's 1pm MobileFrontend deploy?

MaxSem added a comment.Jul 8 2013, 6:41 PM

We will deploy it during our usual window tomorow.