Page MenuHomePhabricator

VipsScaler test page should strip File: prefix from filename
Closed, ResolvedPublic

Description

Author: sumanah

Description:
"There are problems with some of your input File on this wiki: Could not process requested file. Check that it exists on this wiki." even though file exists

To reproduce:

Go to https://test2.wikipedia.org/wiki/File:Bug35047-17.png on test2.wikipedia.org and verify that it exists.

Go to https://test2.wikipedia.org/wiki/Special:VipsTest and insert File:Bug35047-17.png for "File on this wiki".

Hit "Generate thumbnails" with all the other settings left to default.

Expected behavior:

Return a thumbnail.

Observed behavior:

Page returns with error:

There are problems with some of your input

File on this wiki: Could not process requested file. Check that it exists on this wiki.


Version: unspecified
Severity: enhancement

Attached:

vips-scaler-bug.png (479×1 px, 97 KB)

Details

Reference
bz51149

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:42 AM
bzimport set Reference to bz51149.

Created attachment 12825
screeny

When entering the file to test, don't put "File:" at the beginning. Just the file name. Let me know if that works for you or not.

Attached:

vipz.png (718×817 px, 363 KB)

Indeed it is working when stripping the File prefix. Maybe we could attempt to generate a Title object out of the user input, and if it is part of the NS_FILE namespace, just use the name.

Sounds fine. I'll set the priority to low, though. Easiest thing to do is insert extra text on that page saying "Please don't include the 'File:' prefix." Yeah, it's the lazy way, but hopefully in about a week we won't need this much.

Sumanah: Let's go ahead with the communications on Vips, this isn't a blocker.

This would be an easy fix. I could probably do it.

Change 73183 had a related patch set uploaded by Brian Wolff:
Have Special:VipsTest recognize things with File: prefix

https://gerrit.wikimedia.org/r/73183

Jan/Brian: can you two get this tested and merged on Monday?

(In reply to comment #7)

Jan/Brian: can you two get this tested and merged on Monday?

Well I can't +2 my own patch (and currently don't have the relative vips binaries installed to actually test). Jan doesn't have +2 rights on the repo, so just by ourselves, probably not.

Change 73183 merged by Aaron Schulz:
Have Special:VipsTest recognize things with File: prefix

https://gerrit.wikimedia.org/r/73183

Thanks all (including Aaron) ;)

Obviously, we'll need to make sure the latest extension code is branched for any deploy of Vips this coming week (if the other issues are resolved in time).

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:20 AM