Page MenuHomePhabricator

VisualEditor: Reference dialog re-use search form doesn't recognise uppercase group names
Closed, ResolvedPublicBUG REPORT

Description

The re-use tab in the reference dialog allows searching for group names. This was always possible. However, it doesn't work when the group name is uppercase or contains an uppercase character. For example, it works when the group name is "note" but not when the group name is "A". It doesn't matter if I search for "a" or "A", it's not found.

Turns out the relevant code is incomplete ever since it was written in 2013, see https://gerrit.wikimedia.org/r/70364. The relevant ticket was T51733: VisualEditor: Support creation/editing of references using an existing ref-name.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:00 AM
bzimport set Reference to bz51838.
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 12:24 PM
Aklapper removed a subscriber: rmoen.
thiemowmde subscribed.

I'm not sure what's missing here. The group name always was searchable ever since the code was added in June 2013. I just tested it and it works with and without Citoid. Maybe the code was not deployed when this ticket was written?

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/70364/27/modules/ve/ui/widgets/ve.ui.MWReferenceSearchWidget.js#123

thiemowmde claimed this task.
thiemowmde changed the subtype of this task from "Feature Request" to "Bug Report".

Change #1055393 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Fix reference search not working with uppercase groups/names

https://gerrit.wikimedia.org/r/1055393

thiemowmde renamed this task from VisualEditor: Reference dialog re-use search form should recognise group names to VisualEditor: Reference dialog re-use search form doesn't recognise uppercase group names.Jul 19 2024, 9:45 AM
thiemowmde updated the task description. (Show Details)

Change #1055393 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Fix reference search not working with uppercase groups/names

https://gerrit.wikimedia.org/r/1055393