Page MenuHomePhabricator

[TUX] Discard changes only works the second time
Closed, ResolvedPublic


  1. Go to
  2. Open a short message which has suggestions and existing translation
  3. Apply a suggestion
  4. Click discard changes

Observed: Text gets reverted but button does not disappear until clicked the second time
Expected: Button disappears

Git bisect points to:
commit 7eaee736c75743fc67a4a9c0253fa25a84fb7ef6
Author: Santhosh Thottingal <>
Date: Tue Apr 9 14:33:51 2013 +0530

Fix text change detection in IE

Introduce textchange event that get triggered when something changed
on input fields.

Refactor translation textarea construction. Set the value before
starting listening to events. Listen events only with one listener.
Set the two dirty flags together for consistency.

This eliminates the "You have unchanged saves" popup appearing in IE
even when there were no changes.

This fixes the case when it was impossible to get rid of unsaved
status for messages which have no existing status.

Bug: 47019
Bug: 46266
Change-Id: Ib5a7fecdf3cc42c7f5463bb03cae2326e1a3afbc

Version: master
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:58 AM
bzimport set Reference to bz52623.

Change 78190 had a related patch set uploaded by Nikerabbit:
Fix discard button in Chrome

Change 78190 merged by jenkins-bot:
Fix discard button in Chrome