Page MenuHomePhabricator
Create Task
Maniphest T54966

TemplateData: Properties "default" and "deprecated" should be InterfaceText instead of string
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Original bug title:

key "default" should be InterfaceText rather than string

"The default value or description thereof."
Needs translation because
a) The default value may depend on the user's chosen language
b) If a description is supplied it should be in the user's language

a) is maybe arguable but b) is definitely an issue.

Details

Reference
bz52966
SubjectRepoBranchLines +/-
[BREAKING CHANGE] Change "default" property to InterfaceTextmediawiki/extensions/TemplateDatamaster+80 -28
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:53 AM
• bzimport added projects: TemplateData, good first task, I18n.
• bzimport set Reference to bz52966.
Rillke created this task.Aug 17 2013, 11:53 AM
Krinkle added a comment.Aug 26 2013, 10:53 PM

Same for the string value of "deprecated".

revi subscribed.Jan 2 2015, 9:42 AM
• Elitre subscribed.Feb 17 2015, 8:09 PM
gerritbot subscribed.Mar 9 2015, 9:45 PM

Change 195451 had a related patch set uploaded (by Mooeypoo):
Make default property interfaceText

https://gerrit.wikimedia.org/r/195451

gerritbot added a project: Patch-For-Review.Mar 9 2015, 9:45 PM
Mooeypoo claimed this task.Mar 9 2015, 9:48 PM
Mooeypoo moved this task from Backlog to Doing on the TemplateData board.
Krinkle updated the task description. (Show Details)Mar 9 2015, 9:59 PM
Krinkle set Security to None.
gerritbot added a comment.Apr 2 2015, 7:56 AM

Change 195451 merged by jenkins-bot:
[BREAKING CHANGE] Change "default" property to InterfaceText

https://gerrit.wikimedia.org/r/195451

Krinkle mentioned this in rETDAff77f32e384f: [BREAKING CHANGE] Change "default" property to InterfaceText.Apr 2 2015, 7:56 AM
Mooeypoo mentioned this in rMEXT7ed2a6ae42c8: Updated mediawiki/extensions Project: mediawiki/extensions/TemplateData….Apr 2 2015, 7:56 AM
Jdforrester-WMF closed this task as Resolved.Apr 2 2015, 2:46 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-08_(1.26wmf1), VisualEditor 2014/15 Q4 blockers; removed Patch-For-Review, good first task.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.Apr 2 2015, 3:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits