Page MenuHomePhabricator

Label for link to original uploaded PDF says "Full resolution" instead of something like "Download file"
Closed, ResolvedPublic

Description

Label for link to original uploaded PDF says "Full resolution" instead of something like "Download file". This is clearly misleading.

Noted on bug 52881 by Tomer Cohen.


Version: 1.22.0
Severity: enhancement

Details

Reference
bz53017

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:57 AM
bzimport set Reference to bz53017.

Message is 'show-big-image'. Needs "overriding" for PDFs I guess.

.. but it's actually not always a "download" link. Browsers with PDF.js builtin or any other plugins installed may directly display file contents to user in the browser.

Maybe "Original file"? so it fits both images and PDF files.

Hmm, yeah, you're right. So I guess we just need to improve the text, trivial.

mcdevitd wrote:

Are you proposing to change the text for all file types, or just PDFs?

I think this should at least apply to all file formats where the preview file format is different from the original file format. There is an inconsistency when "Other resolutions" is serving you JPG previews for a TIFF or PNG previews for a SVG but "Full resolution" gives you the original file format, when one might expect full resolution preview in JPG or PNG as well. "Original file" removes the inconsistency.

(In reply to comment #6)

Are you proposing to change the text for all file types, or just PDFs?

Yes, all of them.

Change 95749 had a related patch set uploaded by Bartosz Dziewoński:
Use 'Original file' instead of 'Full resolution' for original file link

https://gerrit.wikimedia.org/r/95749

Change 95749 merged by jenkins-bot:
Use 'Original file' instead of 'Full resolution' for original file link

https://gerrit.wikimedia.org/r/95749