Page MenuHomePhabricator
Create Task
Maniphest T55543

VisualEditor: Editing a <syntaxhighlight> block with the experimental generic editor leads to brokenness because the attributes get blanked
Closed, ResolvedPublic
Actions

Description

Author: wojciech.r

Description:
When I edit existing content in <source> tags, while editing it, error is shown about invalid language specified (lang=) and after saving it puts fragment of HTML code of this tag divs and entities into source of page and my code is broken.

https://www.mediawiki.org/w/index.php?title=VisualEditor:Test&oldid=773552

Version: unspecified
Severity: major

Details

Reference
bz53543

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:03 AM
• bzimport added projects: VE-deploy-2013-09-05, VisualEditor-EditingTools.
• bzimport set Reference to bz53543.
• bzimport created this task.Aug 29 2013, 5:16 PM
gerritbot added a comment.Aug 30 2013, 11:29 PM

Change 82063 had a related patch set uploaded by Esanders:
Round trip alien extensions correctly when edited

https://gerrit.wikimedia.org/r/82063

Esanders added a comment.Aug 30 2013, 11:47 PM

Related bug 53614

Esanders added a comment.Aug 30 2013, 11:47 PM

This fix preserves attributes correctly. The above bug would allow you to edit them.

gerritbot added a comment.Aug 31 2013, 12:44 AM

Change 82063 merged by jenkins-bot:
Round trip alien extensions correctly when edited

https://gerrit.wikimedia.org/r/82063

Jdforrester-WMF added a comment.Aug 31 2013, 2:22 PM

This is now fixed in master, and will be released to MediaWiki.org on Thursday 5 September. Sorry for the disruption.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL