Page MenuHomePhabricator

VisualEditor: Move to using white-space: pre-wrap instead of using nbsp's to fake spaces
Closed, ResolvedPublic8 Story Points

Details

Reference
bz53931

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:02 AM
bzimport set Reference to bz53931.
Catrope created this task.Sep 9 2013, 1:52 AM

From an email conversation I had with Aryeh in January 2012:

(Since I'm thinking about canonicalization of whitespace, a tip: set
white-space: pre-wrap on any contenteditable regions you use, and
wherever you use them.  This will stop you from needing to use nbsp's
in ways they were never intended to be used, which causes a variety of
subtle bugs.  See
http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#canonical-space-sequences
for a basic explanation, and click the first "View Comments" at
http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#the-inserttext-command
for a more detailed explanation of how nbsp substitution works in
practice.)

Still valid:

./src/ce/nodes/ve.ce.TextNode.js:		// Replace spaces with   where needed
matmarex added a subscriber: matmarex.

Change 255931 had a related patch set uploaded (by Bartosz Dziewoński):
Use white-space: pre-wrap instead of using   for spaces

https://gerrit.wikimedia.org/r/255931

Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Change 255931 merged by jenkins-bot:
Use white-space: pre-wrap instead of using   for spaces

https://gerrit.wikimedia.org/r/255931

Nnemo added a subscriber: Nnemo.Jan 25 2016, 10:10 PM