Page MenuHomePhabricator

Attempting to use to API to review a revision on a non-stable page gives "Unknown error"
Closed, ResolvedPublic

Description

Try to review a revision on a page for which FlaggedRevs is not enabled, e.g. on testwiki,

action=review&revid=126014

We see

{
    "servedby": "mw1017",
    "error": {
        "code": "unknownerror",
        "info": "Unknown error: \"\""
    }
}

A better error message is needed.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:29 AM
bzimport added a project: FlaggedRevs.
bzimport set Reference to bz54817.
bzimport added a subscriber: Unknown Object (MLST).

Change 331212 had a related patch set uploaded (by TTO):
ApiReview: Make generic error conditionals actually reachable

https://gerrit.wikimedia.org/r/331212

Change 331212 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs] ApiReview: Make generic error conditionals actually reachable

https://gerrit.wikimedia.org/r/331212

TTO claimed this task.