Page MenuHomePhabricator

log files created even with -nolog argument
Closed, ResolvedPublic

Description

Log files are created even if -nolog argument is set.

On the core '2.0' branch, http.py calls logoutput before args are parsed.

The whole log is as follows:
2013-10-02 21:18:41 http.py, 70 in <module>: VERBOSE Starting 1 threads...

This problem was removed from core 'master' when httplib2 was replaced with 'requests'.

To see the line causing this message:

$ git checkout 2.0
...
$ git grep 'Starting.*threads'
pywikibot/comms/http.py:pywikibot.log(u'Starting %(numthreads)i threads...' % locals())

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:35 AM
bzimport set Reference to bz54897.
bzimport added a subscriber: Unknown Object (????).
jayvdb set Security to None.
jayvdb removed a subscriber: Unknown Object (????).
AndyTechGuy subscribed.

I have claimed this task on the GCI website

Change 264218 had a related patch set uploaded (by AndyTechGuy):
Add extra test to reinforce -nolog argument

https://gerrit.wikimedia.org/r/264218

Regarding the task description change, I don't know what this means for the current patch.
Should continue updating this patch even though this specific instance of the error no longer occurs? Or should I simply abandon the change?

The described bug still exists in the 2.0 branch.
Start a new change request to fix it in the 2.0 branch.
Your exist changeset for commands.log may still be useful, so dont abandon it yet.

Change 264471 had a related patch set uploaded (by AndyTechGuy):
Add extra test to reinforce -nolog argument in 2.0

https://gerrit.wikimedia.org/r/264471

Change 264471 abandoned by AndyTechGuy:
Add extra test to reinforce -nolog argument in 2.0

Reason:
This commit has been uploaded to the wrong branch.

https://gerrit.wikimedia.org/r/264471

Change 264472 had a related patch set uploaded (by AndyTechGuy):
Add extra test for -nolog argument in 2.0 branch

https://gerrit.wikimedia.org/r/264472

I found the same problem for master branch

Change 266720 had a related patch set uploaded (by Xqt):
[bugfix] -nolog option must also disable general '*' setting

https://gerrit.wikimedia.org/r/266720

Change 266735 had a related patch set uploaded (by Xqt):
[bugfix] -nolog option must also disable general '*' setting

https://gerrit.wikimedia.org/r/266735

Change 266735 abandoned by Xqt:
[bugfix] -nolog option must also disable general '*' setting

Reason:
Not thanks! To complicated, to many edit conflict to many patch sets to pick to much work to sync 2.0 with master. I keep away from it.

https://gerrit.wikimedia.org/r/266735

Change 266720 merged by jenkins-bot:
[bugfix] -nolog option must also disable general '*' setting

https://gerrit.wikimedia.org/r/266720

Change 264472 abandoned by Xqt:
Add extra test for -nolog argument in 2.0 branch

Reason:
master branch should be used. 2.0 seems deprecated.

https://gerrit.wikimedia.org/r/264472