Page MenuHomePhabricator

Self closing tags
Closed, ResolvedPublic


Originally from:
Reported by: Anonymous user / bachinchi
Created on: 2011-08-28 15:13:07
Subject: Self closing tags
Original description:
Since MW 1.16 wgHtml5 and wgWellFormedXml are turned on by default. And still changes things like <br> to <br />, I don't see any reason for that. There are three options we have here:

  • Stop making these kind of changes
  • Make these changes "complete" and add some tags that are not fixed (eg. <hr> to <hr /> )
  • Do just the opposite, and let the MW fix the tags (eg. a <br/> to <br>, etc)

I like the third option, because it makes the code easier to read for editors.
In the attachment there's a patch to apply the third option.

Pywikipedia [http] trunk/pywikipedia (r9462, 2011/08/28, 11:34:03)
Python 2.7 (r27:82500, Aug 07 2010, 16:54:59) [GCC]
use_api = True
use_api_login = True

Version: unspecified
Severity: enhancement
See Also:



Related Objects


Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:28 AM
bzimport set Reference to bz55236.
bzimport added a subscriber: Unknown Object (????).

&lt;hr&gt; will be replaced by mediawiki syntax ----
look at cosmetic\_changes.fixHtml\(\)

Ups, didn't remember that \(since I have seen plenty of hr in templates\), so you can't ignore the second line in patch.

The bug says in cosmetic changes the code needs to change <br /> to <br> instead of doing vice versa. I don't have any opinion on this

jayvdb set Security to None.
jayvdb removed a subscriber: Unknown Object (????).

This still occurs in cosmetic change validXhtml, in both compat and core

Change 176640 had a related patch set uploaded (by John Vandenberg):
Replace cosmetic change 'validXhtml' with 'HTML' fix


Change 176640 merged by jenkins-bot:
Replace cosmetic change 'validXhtml' with 'HTML' fix

jayvdb claimed this task.