Page MenuHomePhabricator
Create Task
Maniphest T57430

Use FormSpecialPage rather than just raw HTMLForm in a special page
Closed, ResolvedPublic
Actions

Description

Title says it all. Special pages that use HTMLForm already should just use FormSpecialPage to avoid duplicating code.

Details

Reference
bz55430
ProjectBranchLines +/-Subject
mediawiki/extensions/TranslationNotificationsmaster+36 -40Make SpecialTranslatorSignup use FormSpecialPage
mediawiki/extensions/TranslationNotificationsmaster+68 -67Convert SpecialNotifyTranslators to FormSpecialPage
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:13 AM
• bzimport added projects: MediaWiki-extensions-TranslationNotifications, patch-welcome.
• bzimport set Reference to bz55430.
• bzimport added a subscriber: Unknown Object (MLST).
Krinkle added a project: Technical-Debt.Dec 10 2014, 2:03 PM
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2015, 4:38 PM
gerritbot added a subscriber: gerritbot.May 22 2016, 9:33 AM

Change 290052 had a related patch set uploaded (by Glaisher):
Convert SpecialNotifyTranslators to FormSpecialPage

https://gerrit.wikimedia.org/r/290052

gerritbot added a comment.May 23 2016, 6:42 AM

Change 290052 merged by jenkins-bot:
Convert SpecialNotifyTranslators to FormSpecialPage

https://gerrit.wikimedia.org/r/290052

• Nikerabbit added a subscriber: • Nikerabbit.Jun 7 2016, 8:45 AM

I guess Special:TranslatorSignup could use this also, hence this bug is still open.

• Nikerabbit removed a project: Patch-For-Review.Jun 7 2016, 8:45 AM
• Nikerabbit updated the task description. (Show Details)
Glaisher claimed this task.Jun 7 2016, 12:47 PM
gerritbot added a comment.Jun 7 2016, 5:26 PM

Change 293131 had a related patch set uploaded (by Glaisher):
Make SpecialTranslatorSignup use FormSpecialPage

https://gerrit.wikimedia.org/r/293131

gerritbot added a comment.Jun 8 2016, 10:34 PM

Change 293131 merged by jenkins-bot:
Make SpecialTranslatorSignup use FormSpecialPage

https://gerrit.wikimedia.org/r/293131

Glaisher closed this task as Resolved.Jun 9 2016, 7:58 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL