Page MenuHomePhabricator

ResourceLoaderULSModule::getModifiedTime updates continuously
Closed, ResolvedPublic

Description

ResourceLoaderULSModule updates its modified time whenever ResourceLoaderContext::getLanguage varies. ResourceLoaderContext::getLanguage varies gets the language via the 'lang' parameter on the module request. The lang parameter is set in mediawiki.js to wgUserLanguage.

Result: the version of ext.uls.languagenames is updated continuously as users with different language settings hit the site, with the effect that practically every request for the module (and any other module fetched in the same request) is uncached.

To confirm this bug report, you can go to enwiki and check mw.loader.getVersion('ext.uls.languagenames'); . Then reload and check again.

'mediawiki.language.data' appears to likewise update continuously.


Version: unspecified
Severity: major

Details

Reference
bz56856

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:25 AM
bzimport set Reference to bz56856.
ori created this task.Nov 10 2013, 10:11 AM

Change 94708 had a related patch set uploaded by Nikerabbit:
ResourceLoaderULSModule::getModifiedTime updates continuously

https://gerrit.wikimedia.org/r/94708

Change 94708 merged by jenkins-bot:
ResourceLoaderULSModule::getModifiedTime updates continuously

https://gerrit.wikimedia.org/r/94708