Page MenuHomePhabricator

Use mw.user.tokens.get( 'editToken' )
Closed, ResolvedPublic

Description

Since the introduction of mw.user in I708006fd6733cac89128bc76a1cd34c0d091c371

Calling:
mw.user.tokens.get( 'editToken' )

Returns an edit token.
We should probably now be able to reduce or kill our getToken code..


Version: unspecified
Severity: enhancement

Details

Reference
bz57559

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz57559.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1451

Change 103887 had a related patch set uploaded by Kaldari:
Migrating some use of api.getToken() to mw.user.tokens.get()

https://gerrit.wikimedia.org/r/103887

Change 103887 abandoned by Kaldari:
Migrating some use of api.getToken() to mw.user.tokens.get()

Reason:
Apparently this is not what was wanted.

https://gerrit.wikimedia.org/r/103887

Change 104160 had a related patch set uploaded by Kaldari:
Add short-curcuit in api.getTokens for tokens availble in user.tokens

https://gerrit.wikimedia.org/r/104160

Ryan's patch kicks this off but we have to upstream a fair bit to core before we can do this... :(

Change 104160 merged by jenkins-bot:
Add short-curcuit in api.getTokens for tokens availble in user.tokens

https://gerrit.wikimedia.org/r/104160

I've opened two more specific bugs:

  • bug 59148
  • bug 59149

We've done all we can here for the time being.

Change 105116 had a related patch set uploaded by Kaldari:
Add short-curcuit in api.getTokens for tokens availble in user.tokens

https://gerrit.wikimedia.org/r/105116

Change 105116 merged by jenkins-bot:
Add short-circuit in api.getTokens for tokens available in user.tokens

https://gerrit.wikimedia.org/r/105116