Page MenuHomePhabricator

VisualEditor: If copying from one VE instance to another, pasted links result in broken wikitext (external URL, internal link format)
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Open the editor for a page which contains a link
2.Copy the link
3.Now open VE for another article and paste the copied link onto it
4.Save the page

Observed Result:

The copied link appears as a plain text on the read mode where as in the Edit Source/Edit mode it appears as a link


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=58138

Details

Reference
bz58136

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz58136.
Ryasmeen created this task.Dec 7 2013, 12:32 AM

Page: Observe the second "Edit source" text on the page:
http://en.wikipedia.beta.wmflabs.org/wiki/To_edit_source

Test Environment: Betalabs
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5

Change 100422 had a related patch set uploaded by Esanders:
Only strip style attributes on rich paste from VE

https://gerrit.wikimedia.org/r/100422

Change 100493 had a related patch set uploaded by Jforrester:
Only strip style attributes on rich paste from VE

https://gerrit.wikimedia.org/r/100493

Change 100422 merged by jenkins-bot:
Only strip style attributes on rich paste from VE

https://gerrit.wikimedia.org/r/100422

Change 100493 merged by jenkins-bot:
Only strip style attributes on rich paste from VE

https://gerrit.wikimedia.org/r/100493

A fix for this is going out in about 4 minutes' time. Sorry for the disruption.

Verified in betalabs

This issue is still occurring for following case:

1.Open the editor for a page "A" which contains a link to another page "B"
2.Copy the link and Paste it into "B"
3.Save the page

Observed Result:
The link to the same page is appearing as plain text in the read mode.

Found in :http://en.wikipedia.beta.wmflabs.org/wiki/The_paste_destination

Change 105706 had a related patch set uploaded by Esanders:
Always use absolute URLs in external links in the clipboard

https://gerrit.wikimedia.org/r/105706

Change 106253 had a related patch set uploaded by Esanders:
Always use absolute URLs in external links in the clipboard

https://gerrit.wikimedia.org/r/106253

Change 106253 merged by jenkins-bot:
Always use absolute URLs in external links in the clipboard

https://gerrit.wikimedia.org/r/106253

Change 105706 merged by jenkins-bot:
Support external links in MWInternalLinkAnnotation

https://gerrit.wikimedia.org/r/105706

The issue described later in this bug still exists in test.Again giving the steps here:
This issue is still occurring for following case:

1.Open the editor for a page "A" which contains a link to another page "B"
2.Copy the link and Paste it into "B"
3.Save the page

Observed Result:
The link to the same page is appearing as plain text in the read mode.

The testing environment is test2, wmf 11.
Broswer:Chrome/Firefox

  • Bug 59216 has been marked as a duplicate of this bug. ***

The last fix was merged on 15th Jan. The test environment you point to says it is running code from 14th Jan. Please re-open if broken with master.

Ed, I tested it on 16th december(Last thursday) after the deployment on test2.So it should have been merged to test2 by that time right? Also, I am still getting it on test2

Sorry 16th January :)

Change 108954 had a related patch set uploaded by Esanders:
Relativise URLs against target document

https://gerrit.wikimedia.org/r/108954

Change 108953 had a related patch set uploaded by Krinkle:
Resolve URLs against correct document when copying.

https://gerrit.wikimedia.org/r/108953

Possibly now fixed. Hopefully.

Change 108954 merged by jenkins-bot:
Relativise URLs against target document

https://gerrit.wikimedia.org/r/108954

Verified the fix on test 2