Page MenuHomePhabricator

Get rid of $wgEnableNewpagesUserFilter
Closed, ResolvedPublic

Description

This config variables dates back to r34065 from April 2008. Quoth Brion:

/**

  • Enable user search in Special:Newpages
  • This is really a temporary hack around an index install bug on some Wikipedias.
  • Kill it once fixed. */

$wgEnableNewpagesUserFilter is still set to false on some wikis:

'wgEnableNewpagesUserFilter' => array(
'default' => true,
'frwiki' => false,
'nlwiki' => false,
'svwiki' => false,
),

I can't find any bug report or other reason why this config variable even exists, or why it is set to false on these three wikis.

I think it is time to get rid of this.


Version: unspecified
Severity: normal

Details

Reference
bz58932

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:24 AM
bzimport added a project: MediaWiki-Patrolling.
bzimport set Reference to bz58932.
TTO created this task.Dec 24 2013, 10:48 AM

Someone with access to the cluster should run "show indexes in recentchanges" on frwiki, nlwiki, and svwiki to ensure the rc_user_text index has been added, and then we can kill it.

CC-ing Sean.

Confirming that the rc_user_text index exists on frwiki, nlwiki, and svwiki.

Change 141100 had a related patch set uploaded by TTO:
Kill $wgEnableNewpagesUserFilter

https://gerrit.wikimedia.org/r/141100

Change 141105 had a related patch set uploaded by TTO:
Kill $wgEnableNewpagesUserFilter

https://gerrit.wikimedia.org/r/141105

Change 141105 merged by jenkins-bot:
Kill $wgEnableNewpagesUserFilter

https://gerrit.wikimedia.org/r/141105

Merged, so apparently fixed. Leaving TTO as assignee so he can take the glory.

Oi! Didn't notice that there were actually two patches for this bug, so this'll have to wait till https://gerrit.wikimedia.org/r/141105 gets merged.

Change 141100 merged by jenkins-bot:
Kill $wgEnableNewpagesUserFilter

https://gerrit.wikimedia.org/r/141100