Page MenuHomePhabricator

beta labs: upload image fails
Closed, ResolvedPublic

Description

broken thumbs on images displayed after page refresh

Seen in Firefox on beta labs 27 Dec

as a logged in user at http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Uploads

upload an image
fill in description, click Submit
get 'Uploading image' dialog and spinner

  • Spinner stops with no error. Page should display new image with description, but does not.
  • Refresh page. Uploaded images may or may not display a broken thumbnail. The broken thumbs shown in the attachment were created manually via Chrome.

Version: unspecified
Severity: normal

Attached:

Details

Reference
bz59009

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:29 AM
bzimport set Reference to bz59009.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1587

This sounds like it's due to the 500 errors on beta labs?

I don't think it was 503s, but it may have been some other local condition at the time.

FWIW, I think we have all but eliminated the 503 errors on beta at this point.

http://commons.wikimedia.beta.wmflabs.org/w/api.php?useformat=mobile&r=0.49145484203472733&origin=http://en.m.wikipedia.beta.wmflabs.org is returning with a token error

{"servedby":"deployment-apache33","error":{"code":"badtoken","info":"Invalid token"}}

Not sure why..

I'm still not seeing files uploaded via the Mobile interface on beta labs.

I can see the POST for the Mobile upload in api.log but I have not found any errors associated with it in any logs.

Regular UploadWizard continues to work properly.

Last successful upload was Dec 30

I3e927ec9b9d171cc227da25be43643e6ce21a308 < This might have introduced it. Do we know exactly when the problem occurred?

(merged Mon Dec 30 22:27:18 2013 +0000)

Max helped me confirm that reverting this patch fixes the problem.

Change 105108 had a related patch set uploaded by Jdlrobson:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/105108

Change 105108 merged by jenkins-bot:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/105108

Change 105112 had a related patch set uploaded by MaxSem:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/105112

Change 105112 merged by MaxSem:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/105112

Change 107264 had a related patch set uploaded by Kaldari:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/107264

This is being cherry picked to enwiki - somehow the fix didn't make it there.

Change 107264 merged by Kaldari:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/107264