Page MenuHomePhabricator

Remove deprecated $wgCopyrightIcon
Closed, ResolvedPublic

Description

Author: ginger

Description:
Per Bug 59113 we looked around the code for things that have been deprecated
and found $wgCopyrightIcon at includes/DefaultSettings.php:5812


Version: 1.23.0
Severity: enhancement

Details

Reference
bz60459

Related Objects

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:04 AM
bzimport set Reference to bz60459.
bzimport added a subscriber: Unknown Object (MLST).

andnlnbn18 wrote:

Can I work on it?

Change 109896 had a related patch set uploaded by Lekshmi:
Changed deprecated $wgCopyrightIcon

https://gerrit.wikimedia.org/r/109896

Change 109903 had a related patch set uploaded by Lekshmi:
Changed deprecated $wgCopyrightIcon

https://gerrit.wikimedia.org/r/109903

Change 109896 abandoned by Lekshmi:
Changed deprecated $wgCopyrightIcon

Reason:
Abandoned due to rebase error

https://gerrit.wikimedia.org/r/109896

andnlnbn18 wrote:

Andre: I got a comment on 14th patch as "This migration has to happen in two steps: First of all $wgFooterIcons['copyright']['copyright'] and $wgCopyrightIcon have to be made fully compatible/ equivalent. Then we can update Wikimedia's configuration etc. Later on the backwards compatibility can be removed, but no earlier than in the next MediaWiki version (I'd even suggest waiting two versions here)."

Does this mean it'll take more time for changes to get commited?

Change 148570 had a related patch set uploaded by Withoutaname:
Remove deprecated $wgCopyrightIcon

https://gerrit.wikimedia.org/r/148570

Change 148570 had a related patch set uploaded (by Reedy):
Remove deprecated $wgCopyrightIcon

https://gerrit.wikimedia.org/r/148570

WMF config is still using $wgCoprightIcon

Paladox added a subscriber: Paladox.

According to https://www.mediawiki.org/wiki/Manual:$wgCopyrightIcon it was removed in MediaWiki 1.27.

Change 148570 abandoned by Legoktm:
Remove deprecated $wgCopyrightIcon

Reason:
Already done in master

https://gerrit.wikimedia.org/r/148570