| Aklapper | |
| Feb 13 2014, 1:02 AM |
| F13349: Screen_Shot_2014-02-13_at_14.28.49.png | |
| Nov 22 2014, 3:06 AM |
"Saved Searches" section now displays Saved Reports (a new feature in 4.4) at the bottom, but our custom code is rather interesting here (bug 59889).
Applying my patch in https://gerrit.wikimedia.org/r/#/c/113051/ broke the line height, the line wrapping, and introduced indentation for the first item.
This is a regression due to upgrading to 4.4 but I decided to keep it as we have "Saved Reports" now at least (though they cannot be shared).
Version: wmf-deployment
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Aklapper | T63288 [Bugzilla 4.4 regression] Fix line height + line wrapping for Saved Searches + Saved Reports in sidebar | |||
| Resolved | None | T61889 Clean up custom footer.html.tmpl and adapt upstream's included subpages structure (blocks "saved reports" in 4.4) |
Change 113073 had a related patch set uploaded by Aklapper:
Fix UI regression in side bar introduced in bug 59889
The saved searches area looks so cluttered :( Hope it gets back to its original shape soon.
Created attachment 14582
Screenshot of collapsed saved search links
Saved Searches links are no longer on their own line but collapsed
Attached:
Looks good to me: No indentation of first item anymore, correct line height, line wrapping, and the "Saved Reports" section between "Saved Searches" and "Links" is only shown when the user has at least one saved report.