Page MenuHomePhabricator

[Bugzilla 4.4 regression] Fix line height + line wrapping for Saved Searches + Saved Reports in sidebar
Closed, ResolvedPublic


"Saved Searches" section now displays Saved Reports (a new feature in 4.4) at the bottom, but our custom code is rather interesting here (bug 59889).

Applying my patch in broke the line height, the line wrapping, and introduced indentation for the first item.

This is a regression due to upgrading to 4.4 but I decided to keep it as we have "Saved Reports" now at least (though they cannot be shared).

Version: wmf-deployment
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:06 AM
bzimport set Reference to bz61288.
  • Bug 61290 has been marked as a duplicate of this bug. ***

Change 113073 had a related patch set uploaded by Aklapper:
Fix UI regression in side bar introduced in bug 59889

The saved searches area looks so cluttered :( Hope it gets back to its original shape soon.

Created attachment 14582
Screenshot of collapsed saved search links

Saved Searches links are no longer on their own line but collapsed


Screen_Shot_2014-02-13_at_14.28.49.png (534×348 px, 46 KB)

Change 113073 merged by Dzahn:
Fix UI regression in side bar introduced in bug 59889

Looks good to me: No indentation of first item anymore, correct line height, line wrapping, and the "Saved Reports" section between "Saved Searches" and "Links" is only shown when the user has at least one saved report.

Thanks for the timely fix. :-)