[Bugzilla 4.4 regression] Fix line height + line wrapping for Saved Searches + Saved Reports in sidebar
Closed, ResolvedPublic

Description

"Saved Searches" section now displays Saved Reports (a new feature in 4.4) at the bottom, but our custom code is rather interesting here (bug 59889).

Applying my patch in https://gerrit.wikimedia.org/r/#/c/113051/ broke the line height, the line wrapping, and introduced indentation for the first item.

This is a regression due to upgrading to 4.4 but I decided to keep it as we have "Saved Reports" now at least (though they cannot be shared).


Version: wmf-deployment
Severity: normal

bzimport added a project: Wikimedia-Bugzilla.Via ConduitNov 22 2014, 3:06 AM
bzimport set Reference to bz61288.
Aklapper created this task.Via LegacyFeb 13 2014, 1:02 AM
TTO added a comment.Via ConduitFeb 13 2014, 1:33 AM
  • Bug 61290 has been marked as a duplicate of this bug. ***
gerritbot added a comment.Via ConduitFeb 13 2014, 2:23 AM

Change 113073 had a related patch set uploaded by Aklapper:
Fix UI regression in side bar introduced in bug 59889

https://gerrit.wikimedia.org/r/113073

01tonythomas added a comment.Via ConduitFeb 13 2014, 1:03 PM

The saved searches area looks so cluttered :( Hope it gets back to its original shape soon.

Krinkle added a comment.Via ConduitFeb 13 2014, 10:30 PM

Created attachment 14582
Screenshot of collapsed saved search links

Saved Searches links are no longer on their own line but collapsed

Attached:

gerritbot added a comment.Via ConduitFeb 14 2014, 8:18 PM

Change 113073 merged by Dzahn:
Fix UI regression in side bar introduced in bug 59889

https://gerrit.wikimedia.org/r/113073

Aklapper added a comment.Via ConduitFeb 14 2014, 8:31 PM

Looks good to me: No indentation of first item anymore, correct line height, line wrapping, and the "Saved Reports" section between "Saved Searches" and "Links" is only shown when the user has at least one saved report.

Deskana added a comment.Via ConduitFeb 15 2014, 1:02 AM

Thanks for the timely fix. :-)

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.