Page MenuHomePhabricator

MediaWiki delete action doesn't work with pages that have been occupied by Flow
Closed, DeclinedPublic

Description

When a page has been occupied by the Flow extension, the standard delete action no longer functions. This should be fixed.


Version: unspecified
Severity: normal

Details

Reference
bz61730

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz61730.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to MZMcBride from comment #0)

When a page has been occupied by the Flow extension, the standard delete
action no longer functions. This should be fixed.

Sorry, I should've been clearer here: by "standard delete action" I mean index.php?action=delete.

It's unclear what the right behavior here is, and it may change depending on how we enable Flow on pages in the future.

If Flow is enabled on some page, visiting it shows the Flow header and topics for that page. The wikitext of the page isn't shown, so whether it's deleted or changed (which you can currently still do through the API) has no effect. Behind the scenes Flow calls ensureFlowRevision(), which creates a dummy "This talk page has been taken over by a [https://www.mediawiki.org/wiki/Special:MyLanguage/Flow_Portal Flow board]" revision, but users won't see this text until Flow is disabled on that page.

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:42 AM

This might have been resolved for Flow boards that aren't in wgFlowOccupyPages list by gerrit 175574 (towards T76778).

To test, try ?action=delete on a Flow board that someone created through the new-topic or edit-header API, e.g. https://test.wikipedia.org/wiki/User_talk:SPage_%28WMF%29/New_Board_from_new-topic_4

This might have been resolved for Flow boardds that aren't in wgFlowOccupyPages list by gerrit 175574 (towards T76778).

To test, try ?action=delete on a Flow board that someone created through the new-topic or edit-header API, e.g. https://test.wikipedia.org/wiki/User_talk:SPage_%28WMF%29/New_Board_from_new-topic_4

Confirmed: hacking the URL to use &action=delete does work. I deleted the example you linked to (which was previously a normal Flow Board).

Doing a "Restore" action doesn't work though. It just results in a wikipage with this content:

{"flow-workflow":"s9c1puxfwguhvdwt"}

and that's all that was visible when viewing the deleted page, too.

(The 1 topic that was attached to the board, is Topic:S9c1puyfrauenodp)

EBernhardson closed this task as Declined.Jan 17 2015, 12:01 AM
EBernhardson claimed this task.

The standard delete works, just not on pages occupied via wgFlowOccupyPages as they are explicitly enabled. Any flow board enabled via content handler is deletable.

wgFlowOccupyPages will go away one of these days, sooner rather than later.