| JAnD | |
| Feb 27 2014, 7:32 PM |
| F3637006: ht_patch | |
| Mar 15 2016, 11:03 AM |
| F3636160: harvest_template.py | |
| Mar 15 2016, 8:08 AM |
It would be very useful if harvest_template could add properties type item also in case, when they are not formatted like [[foo]]
example:
city = [[Berlin]] is OK
state= Germany is not OK even if the template formats this as link.
example of command:
harvest_template -template:"Infobox" state P123 -islink
I tried to upload it via uploader, but I don't know, where is it now.
I tried to run git on windows, but it was too difficult for me
There is some ugly patch including commnted old part of code + already merged patch for external-id
originally form https://www.wikidata.org/w/index.php?title=User:Underlying_lk/harvest_template.py&oldid=117969578
I tried to upload it via uploader, but I don't know, where is it now.
See :
https://www.mediawiki.org/wiki/Gerrit_patch_uploader
https://tools.wmflabs.org/gerrit-patch-uploader/
Result from uploading patch: /data/project/gerrit-patch-uploader/git/bin/git clone --depth=1 ssh://gerrit/pywikibot/core /tmp/3585641.1.webgrid-lighttpd/tmpSE65T9 Cloning into '/tmp/3585641.1.webgrid-lighttpd/tmpSE65T9'... Total 964 (delta 403), reused 367 (delta 179) /data/project/gerrit-patch-uploader/git/bin/git rev-parse --abbrev-ref HEAD Will commit to branch: master
But I am not able to find, where is my patch now. Or will be visible after some time?
patch failed:
git.exe am --ignore-space-change "C:\pwb\GIT\core\ht_patch.patch" Patch format detection failed. Fail
I checked your code subitted above and I found out that your local repository is 3 years behind the current framework release. Please update your bot first and verify whether this bug still exists.
Yes, bug still exists, harvest_template.py cannot harves not-formated statements.
when I posted this patch, it worked.
I thin it will not be big problem to implement it, but I am not the right one to do it.
Regarding the proposed patch(es) above.
While for individual tasks for personal use these changes may be ok (I also have locally several forks of some scripts:) ), in the current state it will not be accepted in gerrit by reviewers. Since we don't want *always* to treat any plain text in template parameters as a unlinked wikilink and to try to find their item, more code is needed here to define the new option as an optional feature.
This idea is good.
There are many usescases around multiple major wikis, and I think Pasleim's harvest_template analogue already has such a feature enabled.
A patch is welcome.
Change 364117 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[pywikibot/core@master] [DNM] Add support for item without link to harvest_template
Uploaded a refactored version of T64014#2121595.
I think Pasleim's harvest_template analogue already has such a feature enabled.
Yes, it does. Unlike PWB, HarvestTemplates allows only a single parameter to be parsed. If this is to be an optional feature, an overhaul needs to be done to the script.
Change 364117 merged by jenkins-bot:
[pywikibot/core@master] [DNM] Add support for item without link to harvest_template
IMO this feature should be implemented ONLY as optional, because it is not always safe to import blindly any unliked value, and there could be imported some weird values, at least on some wikis. The user operating bot should decide himself if they want to assume such risk or not.
To be clearer, there are templates which are concatenating variable values from articles with some predefined prefixes/sufixes from template to form a page title. For example:
https://en.wikipedia.org/w/index.php?title=Template:Infobox_French_commune
https://en.wikipedia.org/w/index.php?title=Template:Infobox_South_African_town
https://en.wikipedia.org/w/index.php?title=Template:Infobox_German_location
https://nl.wikipedia.org/w/index.php?title=Sjabloon:Infobox_Duitse_plaats_plus
https://ro.wikipedia.org/wiki/Format:Cutie_Localit%C4%83%C8%9Bi_DE
https://ro.wikipedia.org/w/index.php?title=Format:Caset%C4%83Sate
https://sr.wikipedia.org/w/index.php?title=%D0%A8%D0%B0%D0%B1%D0%BB%D0%BE%D0%BD:%D0%9D%D0%B0%D1%81%D0%B5%D1%99%D0%B5%D0%BD%D0%BE_%D0%BC%D1%98%D0%B5%D1%81%D1%82%D0%BE_%D1%83_%D0%91%D0%BE%D1%81%D0%BD%D0%B8_%D0%B8_%D0%A5%D0%B5%D1%80%D1%86%D0%B5%D0%B3%D0%BE%D0%B2%D0%B8%D0%BD%D0%B8
In such cases it's a mistake to get the items of those simples parameters values from articles. This is why such a function to import raw template parameters values must be only optional, and if nobody plans to fix the uncovered problems, these script changes must be reverted.
Change 364475 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[pywikibot/core@master] [IMPR] Enhance argument management in harvest_template.py
Change 364475 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Enhance argument management in harvest_template.py