Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf17] Please round image sizes to whole numbers
Closed, ResolvedPublic

Description

Wikitext code: [[File:Hedrick (1921) - Bartlett.jpg|thumb|Caption]]

Original image dimensions: 920 × 1,216 pixels.

VisualEditor says: 166.32302405498282 × 220 pixels.

Please round to whole numbers of pixels.


Version: unspecified
Severity: minor

Details

Reference
bz62279

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:02 AM
bzimport set Reference to bz62279.

Created attachment 14746
Screen shot of VisualEditor's image dialog, under advanced settings

Attached:

I can't manage to replicate this, not even in betalabs.

http://en.wikipedia.beta.wmflabs.org/wiki/User:Mooeypoo/Test?veaction=edit

I get 166x220 in the media size widget...

I still can't manage to replicate the bug on master or on betalabs, but in any case, height calculations are rounded in this patch: https://gerrit.wikimedia.org/r/#/c/117144/

This should fix instances of this bug.

Apologies, I mean this fix: https://gerrit.wikimedia.org/r/#/c/117161/

(Added Math.round() in the default size conversion in the dm)

Change 117161 had a related patch set uploaded by Mooeypoo:
Enforce width-only default size only on larger images

https://gerrit.wikimedia.org/r/117161

Change 117161 merged by jenkins-bot:
Enforce width-only default size only on larger images

https://gerrit.wikimedia.org/r/117161