jquery.byteLimit doesn't work when the content is pasted using the mouse
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	He7d3r
	Mar 6 2014, 12:52 PM

Description

Screencast showing the bug

If I use the mouse to paste a string which exceeds the edit summary limit, it is not truncated until I click in the summary again, or press some key.

Version: 1.23.0
Severity: normal

Attached:

Details

Reference: bz62319

	Subject	Repo	Branch	Lines +/-
	jquery.lengthLimit: Fix 'cut'/'paste' event handling	mediawiki/core	master	+11 -1

Customize query in gerrit

Related Objects

Mentioned In: T186364: mw.widgets.visibleByteLimit doesn't truncate correctly
Mentioned Here: T186364: mw.widgets.visibleByteLimit doesn't truncate correctly

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:04 AM

• bzimport added a project: MediaWiki-JavaScript.

• bzimport set Reference to bz62319.

• bzimport added a subscriber: Unknown Object (MLST).

He7d3r created this task.Mar 6 2014, 12:52 PM

What browser are you using? The byteLimit plugin is listening for cut/paste events which modern browsers should (do?) fire when pasting content in the manner described.

In addition to keyboard events (of course), it also listens to click events, focus/blur events and the generic change event.

I tested this on Google Chrome 33.0.1750.152 and Firefox 28.0.

matmarex edited projects, added MediaWiki-User-Interface, JavaScript; removed MediaWiki-JavaScript.Dec 31 2014, 12:28 AM

He7d3r awarded a token.Jan 3 2015, 2:15 PM

@He7d3r is this still a problem ? Cause this thing listens to almost every event in the book...

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2015, 4:21 PM

Yep. I was able to reproduce the same behavior shown in the screencast above (using Firefox 43 and Google Chrome 47) at https://test.wikipedia.org/wiki/TEST/T64319

I can confirm now. It's rather tricky though... Especially on my mac...

In T186364#3946864, @matmarex wrote:

In T186364#3942874, @Catrope wrote:

That's amazing. What makes it even better is that while the input listens to key events, it doesn't appear to listen to the paste event, so if you paste using the right-click context menu, the truncation doesn't happen until you type into the input or blur it.

We definitely handle the 'paste' event. I just tried debugging this and it seems that the input's value is not updated until the event handler returns. I don't know if that is the expected behavior, but this deserves a new task.

Change 426966 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] jquery.lengthLimit: Improve event handling

https://gerrit.wikimedia.org/r/426966

gerritbot added a project: Patch-For-Review.Apr 16 2018, 6:48 PM

Change 426966 merged by jenkins-bot:
[mediawiki/core@master] jquery.lengthLimit: Fix 'cut'/'paste' event handling

https://gerrit.wikimedia.org/r/426966

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).May 30 2018, 9:00 PM

TheDJ awarded a token.May 30 2018, 9:42 PM

matmarex closed this task as Resolved.May 30 2018, 10:21 PM

matmarex removed a project: Patch-For-Review.

Jdforrester-WMF added a project: VisualEditor (Current work).Jun 1 2018, 9:33 PM

Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.

Jdforrester-WMF set the point value for this task to 8.Jun 13 2018, 6:26 PM