Page MenuHomePhabricator

implement light inline button style in mediawiki.ui
Closed, ResolvedPublic

Description

The Flow discussion system uses a style for its post interaction buttons "Reply • Edit • Thank" that is even lighter-weight than mw-ui-quiet buttons (bug 62556). This could/should move to core, e.g. a mediawiki.ui.buttons.light module.


Version: unspecified
Severity: normal
URL: https://trello.com/c/wBiXSreC

Details

Reference
bz62744

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz62744.
bzimport added a subscriber: Unknown Object (MLST).

This doesn't necessarily need its own module (if we put it in core, I'm inclined that it should go into mediawiki.button).

I mean mediawiki.ui.button

Change 121101 had a related patch set uploaded by Bencmq:
Add mw-ui-light button style

https://gerrit.wikimedia.org/r/121101

Looking at the complexity of the patch...
The problem with defining a .mw-ui-light style that modifies .mw-ui-button is that it must reset all of mw-ui-button's background, border, font-weight, padding, etc. simply to return to plain inline text. It would be simpler and cleaner to allow the existing mw.ui-{constructive,destructive,progressive,neutral} styles to add their coloring on hover & click to any item. Then we don't need a .mw-ui-light style at all.

This approach would also make mw-ui-quiet simpler; note Shahyar Ghobadpour proposes to get rid of mw-ui-quiet in core.

Change 121101 abandoned by Bencmq:
Add mw-ui-light button style

https://gerrit.wikimedia.org/r/121101

Is this bug still relevant?

Seems to be addressed by the current anchors patch (https://gerrit.wikimedia.org/r/#/c/155856/1). Will propose tagging as such.

I actually meant to link the original anchor patch (https://gerrit.wikimedia.org/r/#/c/150577/14), which is merged.

I'm confused. is this issue fixed or not? If not could you more clearly explain the issue?

Yes, I think it's addressed by https://tools.wmflabs.org/styleguide/desktop/section-6.html#section-6.1 (the classes used for that probably need to be tweaked per bug 70818, but I assume the feature will be kept).

If not, please reopen and explain.