The Flow discussion system uses a style for its post interaction buttons "Reply • Edit • Thank" that is even lighter-weight than mw-ui-quiet buttons (bug 62556). This could/should move to core, e.g. a mediawiki.ui.buttons.light module.
Version: unspecified
Severity: normal
URL: https://trello.com/c/wBiXSreC
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | • Mattflaschen-WMF | T99211 Eliminate $wgUseMediaWikiUIEverywhere, leaving 'on' behavior | |||
| Declined | • Mattflaschen-WMF | T72424 Set $wgUseMediaWikiUIEverywhere = true | |||
| Declined | None | T72913 Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling | |||
| Declined | None | T56360 implement updated appearance to Mediawiki.ui (tracking) | |||
| Resolved | None | T64744 implement light inline button style in mediawiki.ui |
This doesn't necessarily need its own module (if we put it in core, I'm inclined that it should go into mediawiki.button).
Change 121101 had a related patch set uploaded by Bencmq:
Add mw-ui-light button style
Looking at the complexity of the patch...
The problem with defining a .mw-ui-light style that modifies .mw-ui-button is that it must reset all of mw-ui-button's background, border, font-weight, padding, etc. simply to return to plain inline text. It would be simpler and cleaner to allow the existing mw.ui-{constructive,destructive,progressive,neutral} styles to add their coloring on hover & click to any item. Then we don't need a .mw-ui-light style at all.
This approach would also make mw-ui-quiet simpler; note Shahyar Ghobadpour proposes to get rid of mw-ui-quiet in core.
Seems to be addressed by the current anchors patch (https://gerrit.wikimedia.org/r/#/c/155856/1). Will propose tagging as such.
I actually meant to link the original anchor patch (https://gerrit.wikimedia.org/r/#/c/150577/14), which is merged.
I'm confused. is this issue fixed or not? If not could you more clearly explain the issue?
Yes, I think it's addressed by https://tools.wmflabs.org/styleguide/desktop/section-6.html#section-6.1 (the classes used for that probably need to be tweaked per bug 70818, but I assume the feature will be kept).
If not, please reopen and explain.