Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf20] Mobile VE fails to appear in beta labs due to generateCitationFeatures() exploding when citation code isn't loaded
Closed, ResolvedPublic

Description

On http://en.m.wikipedia.beta.wmflabs.org/

Log in to edit
Settings to alpha to get VisualEditor
Attempt to edit any page

A spinner appears and spins forever. The VE UI never appears.


Version: unspecified
Severity: major

Details

Reference
bz63074

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.
bzimport set Reference to bz63074.

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1798

Looks like the problem might be in VisualEditor

TypeError: Expecting a function in instanceof check, but got undefined TypeError {stack: (...), message: "Expecting a function in instanceof check, but got undefined"} load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Clo…:9515
log load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Clo…:9515
handlePending load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Clo…:10492
markModuleReady load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Clo…:10632
nestedAddScript load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Clo…:10639
(anonymous function) load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Clo…:10644
script.onload.script.onreadystatechange load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Clo…:105

Looks like the citation code broke this, sorry. I'll fix it.

Change 120842 had a related patch set uploaded by Catrope:
Make generateCitationFeatures() not explode when citation code isn't loaded

https://gerrit.wikimedia.org/r/120842

Change 120842 merged by jenkins-bot:
Make generateCitationFeatures() not explode when citation code isn't loaded

https://gerrit.wikimedia.org/r/120842