Page MenuHomePhabricator

Search overlay makes unnecessary requests for watch star status
Closed, ResolvedPublic

Description

When logged in on English Wikipedia perform a search for "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" that doesn't match any results

An API request for:
https://en.m.wikipedia.org/w/api.php?format=json&action=query&titles=%7C%7C&prop=info&inprop=watched

is made. This is completely unnecessary.

It would be good if whilst fixing this bug we also created WatchApi that extends Api and removed a lot of the legacy code here...


Version: unspecified
Severity: normal

Details

Reference
bz63317

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz63317.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1823

Change 124281 had a related patch set uploaded by Theopolisme:
Search: Prevent unneeded API requests when there aren't any titles

https://gerrit.wikimedia.org/r/124281

Change 124281 merged by jenkins-bot:
Search: Prevent unneeded API request when there aren't any titles

https://gerrit.wikimedia.org/r/124281