Page MenuHomePhabricator

PHP shims for JSON i18n files are unnecessarily loaded
Closed, ResolvedPublic

Description

From Adrian Lang's email to wikitech-l http://www.gossamer-threads.com/lists/wiki/wikitech/452196:

  • The shims for $wgExtensionMessagesFiles as generated by maintenance/generateJsonI18n.php register a handler for the hook LocalisationCacheRecache when included

That is true even in 1.23; LocalisationCache still includes the shims to get non-message data "For backwards compatibility [...] Variables other than $messages still need to be supported though.".

However, in practice, non-message data are contained in separate files; it is unnecessary to load the shims.


Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63928

Details

Reference
bz63926

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz63926.
bzimport added a subscriber: Unknown Object (MLST).

Change 125925 had a related patch set uploaded by PleaseStand:
Skip loading PHP shims for JSON i18n files

https://gerrit.wikimedia.org/r/125925

Change 125925 merged by jenkins-bot:
Skip loading PHP shims for JSON i18n files

https://gerrit.wikimedia.org/r/125925

Change 127020 had a related patch set uploaded by Siebrand:
Skip loading PHP shims for JSON i18n files

https://gerrit.wikimedia.org/r/127020

Change 127020 merged by jenkins-bot:
Skip loading PHP shims for JSON i18n files

https://gerrit.wikimedia.org/r/127020