Page MenuHomePhabricator

Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()
Closed, ResolvedPublic

Description

Author: mwalker

Description:
I was deploying when about 6 of these scrolled by in the fatal log:

[2014-04-16 23:25:21] Fatal error: Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText() at /usr/local/apache/common-local/php-1.23wmf22/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php on line 179
Server: mw1051
Method: GET
URL: http://en.wikisource.org/wiki/Special:MobileDiff/4864647...4865767
Cookie: <Redacted, but the user was logged in>
Backtrace:
#0 /usr/local/apache/common-local/php-1.23wmf22/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php(179): SpecialMobileDiff->showDiff()
#1 /usr/local/apache/common-local/php-1.23wmf22/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php(105): SpecialMobileDiff->showDiff()
#2 /usr/local/apache/common-local/php-1.23wmf22/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php(39): SpecialMobileDiff->executeWhenAvailable('4864647...48657...')
#3 /usr/local/apache/common-local/php-1.23wmf22/includes/specialpage/SpecialPage.php(379): MobileSpecialPage->execute('4864647...48657...')
#4 /usr/local/apache/common-local/php-1.23wmf22/includes/specialpage/SpecialPageFactory.php(503): SpecialPage->run('4864647...48657...')
#5 /usr/local/apache/common-local/php-1.23wmf22/includes/Wiki.php(285): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#6 /usr/local/apache/common-local/php-1.23wmf22/includes/Wiki.php(588): MediaWiki->performRequest()
#7 /usr/local/apache/common-local/php-1.23wmf22/includes/Wiki.php(447): MediaWiki->main()
#8 /usr/local/apache/common-local/php-1.23wmf22/index.php(46): MediaWiki->run()
#9 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#10 {main}


Version: unspecified
Severity: normal

Details

Reference
bz64037

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz64037.
bzimport added a subscriber: Unknown Object (MLST).

getWarningMessageText is in InlineDifferenceEngine. Sounds like some type checking is needed on the diff objects

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1934

Change 127007 had a related patch set uploaded by Jdlrobson:
Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()"

https://gerrit.wikimedia.org/r/127007

Change 127010 had a related patch set uploaded by Jdlrobson:
Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()"

https://gerrit.wikimedia.org/r/127010

Change 127007 abandoned by Jdlrobson:
Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()"

Reason:
Use other instead :)

https://gerrit.wikimedia.org/r/127007

Change 127010 merged by jenkins-bot:
Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()"

https://gerrit.wikimedia.org/r/127010

Change 127141 had a related patch set uploaded by MaxSem:
Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()"

https://gerrit.wikimedia.org/r/127141

Change 127142 had a related patch set uploaded by MaxSem:
Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()"

https://gerrit.wikimedia.org/r/127142

Change 127141 merged by jenkins-bot:
Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()"

https://gerrit.wikimedia.org/r/127141

Change 127142 merged by jenkins-bot:
Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()"

https://gerrit.wikimedia.org/r/127142