| Fomafix | |
| Apr 21 2014, 9:34 AM |
| F13977: Wikidata-patrol.png | |
| Dec 20 2014, 11:42 PM |
| F13978: Wikidata-patrol2.png | |
| Nov 22 2014, 3:22 AM |
Screenshot of https://www.wikidata.org/w/index.php?title=Q16244272&curid=17868521&diff=121515001&oldid=121231169&uselang=en
The patrol link is misplaced. See screenshot.
Possible solutions are:
.patrollink {
white-space: nowrap;
}or
.patrollink {
clear: left;
display: block;
}or an other position in the DOM tree.
Attached:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add overflow:hidden for .mw-parser-output | mediawiki/core | master | +4 -0 |
Change 127624 had a related patch set uploaded by Gerrit Patch Uploader:
Add clear:both to patrollink
Concerns patrol link on all diff pages when content contains uncleared floating elements.
Change 128966 had a related patch set uploaded by Gerrit Patch Uploader:
Enclose parser output into a div container
The problem is with the location the patrol link is output in. It's just dumped in a very bad place (both technically awkward and in terms of user experience).
Change 128966 abandoned by Bartosz Dziewoński:
Enclose parser output into a div container
Screenshot of https://www.wikidata.org/w/index.php?title=Q16244272&curid=17868521&diff=121515001&oldid=121231169&uselang=en
The problem still exits. See actual screenshot.
Attached:
Hmmm I just checked an unpratrolled edit in Firefox and Chromium and it looks fine. What browser are you using? Is a gadget maybe responsible? Can anyone else reproduce it?
(In reply to Lydia Pintscher from comment #9)
What browser are you using?
I generated the screenshot with Firefox. Other browsers have the same result.
In Wikibase the problem is now mitigated because it uses
.wikibase-entityview {
clear: both;
float: left;
width: 100%;
}In MediaWiki core the problem still exist when the content contains an uncleared floating element.
In Wikibase the problem is there again because it uses again
.wikibase-entityview { clear: both; float: left; }
Change 352768 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/core@master] Add overflow:hidden for .mw-parser-output
@Fomafix: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or do you need any help?
If this task has been resolved in the meantime: Please update the task status (via Add Action... → Change Status in the dropdown menu).
If this task is not resolved and only if you do not plan to work on this task anymore: Please consider removing yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu): That would allow others to work on this (in theory), as others won't think that someone is already working on this. Thanks! :)
@Fomafix: Hi, I'm resetting the task assignee due to inactivity. Please feel free to reclaim this task if you plan to work on this - it would be welcome! Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for more information - thanks!
Change 352768 abandoned by Winston Sung:
[mediawiki/core@master] Add overflow:hidden for .mw-parser-output
Reason:
> Bad solution to the problem