Page MenuHomePhabricator

Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff)
Closed, ResolvedPublic

Description

I'm not sure about the correct alternative, but in some languages, comma-separator is translated as "the punctuation used to separate items in a list" which can be some other thing. See bug 44798.


Version: unspecified
Severity: normal

Details

Reference
bz64302

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:13 AM
bzimport set Reference to bz64302.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1957

How serious is the impact, how many languages are affected in practice? And what is your suggestion, create a new message just for this specific case?

(In reply to Max Semenik from comment #2)

How serious is the impact,

An incorrect punctuation is used.

how many languages are affected in practice?

At least zh and some other zh-based languages, such as nan, cdo, gan, hak, yue or lzh (well traditionally Classical Chinese doesn't use punctuations, but zh_classicalwiki, as well as newly published books targeting ordinary readers, uses them) are affected.

what is your suggestion, create a new message just for this specific case?

Include the punctuation in the message saying "bytes added"? (I assume "days ago" is from human timestamp)

So currently text near mobile-frontend-diffview-bytesadded / mobile-frontend-diffview-bytesremoved is lego work. This message should be written as:

"mobile-frontend-diffview-subtitle": "$1 {{PLURAL:$1|byte|bytes}} added, $2",
"mobile-frontend-diffview-subtitle": "$1 {{PLURAL:$1|byte|bytes}} removed, $2",

and say in doc that $1 is byte change and $2 is a human timestamp.

(In reply to Liangent from comment #4)

"mobile-frontend-diffview-subtitle": "$1 {{PLURAL:$1|byte|bytes}} added,

$2",

"mobile-frontend-diffview-subtitle": "$1 {{PLURAL:$1|byte|bytes}}

removed, $2",

Different keys of course.

We could consider using an icon for date and use the icon as punctuation

Change 130252 had a related patch set uploaded by MaxSem:
Don't misuse comma-separator message

https://gerrit.wikimedia.org/r/130252

Change 130252 merged by jenkins-bot:
Don't misuse comma-separator message

https://gerrit.wikimedia.org/r/130252