Page MenuHomePhabricator

ResourceLoader: Add test to ensure all dependencies have the same targets
Closed, ResolvedPublic

Description

When a resourceloader module has target 'mobile', all its dependencies must also have target 'mobile'.
Please add a test to ensure this. Thanks.
Same for desktop and mabye for future targets, we are not aware right now.

See gerrit 125426 and gerrit 129977, where a new module does not have the target and breaks MobileFrontend.

Feel free to move it to the right component or close it, when not relevant.


Version: 1.24rc
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=64512

Details

Reference
bz64513

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:09 AM
bzimport set Reference to bz64513.
bzimport added a subscriber: Unknown Object (MLST).

Sounds good.

Change 130024 had a related patch set (by Bartosz Dziewoński) published:
ResourceLoader: Test that no modules have unfulfillable dependency targets

https://gerrit.wikimedia.org/r/130024

Change 130024 abandoned by Bartosz Dziewoński:
ResourceLoader: Test that no modules have unfulfillable dependency targets

https://gerrit.wikimedia.org/r/130024

Bartosz thanks for having a go. I agree this would be something useful to have - if not a bit tricky to realise :)

Essentially you'd have to go through every module and then resolve every dependency (including parents of dependencies) to ensure it has the same set of targets.

Change 130024 restored by Bartosz Dziewoński:
ResourceLoader: Test that no modules have unfulfillable dependency targets

https://gerrit.wikimedia.org/r/130024

Change 130024 merged by jenkins-bot:
ResourceLoader: Test that all module dependencies are satisfiable

https://gerrit.wikimedia.org/r/130024

was successfully merged