Maniphest T66565

Consolidate mediawiki.notify module and Toast
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 28 2014, 7:10 PM

Tags

Referenced Files

None

Subscribers

Description

mw.notify( 'foo' )
adds a notification message. It seems with a bit of work this code could serve the same purpose as the Toast.

Note 'mediawiki.notify' also runs with target mobile but is only loaded when needed. This means the code for two notification systems could be loaded.

Version: unspecified
Severity: normal

Details

Reference: bz64565

	Subject	Repo	Branch	Lines +/-
	Style mw.notify in the same way as toasts	mediawiki/extensions/MobileFrontend	master	+3 -0
	mediawiki.notification: Allow skins to style notification area	mediawiki/core	master	+11 -6

Customize query in gerrit

Related Objects

Mentioned In: rMEXT89428d5599b9: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFR57f26dba9658: Style mw.notify in the same way as toasts
rMW3f217db8e6c5: mediawiki.notification: Allow skins to style notification area

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:13 AM

• bzimport added a project: Don't use – MobileFrontend-Hygiene.

• bzimport set Reference to bz64565.

Jdlrobson created this task.Apr 28 2014, 7:10 PM

Jdforrester-WMF edited projects, added Technical-Debt, MobileFrontend-General-or-Unknown; removed Don't use – MobileFrontend-Hygiene.Dec 8 2014, 9:42 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed MobileFrontend-General-or-Unknown.Dec 9 2014, 11:44 PM

Jdlrobson set Security to None.

Jdlrobson moved this task from Incoming to 2016-17 Q4 on the Web-Team-Backlog board.Dec 10 2014, 12:18 AM

Jdlrobson moved this task from 2016-17 Q4 to Triaged but Future on the Web-Team-Backlog board.Apr 10 2015, 6:11 PM

Change 205762 had a related patch set uploaded (by Jdlrobson):
Allow Minerva to style notification area

https://gerrit.wikimedia.org/r/205762

Change 205763 had a related patch set uploaded (by Jdlrobson):
Style mw.notify in the same way as toasts

https://gerrit.wikimedia.org/r/205763

Jdlrobson moved this task from Triaged but Future to 2017-18 Q3 on the Web-Team-Backlog board.May 1 2015, 6:54 PM

Change 205762 merged by jenkins-bot:
mediawiki.notification: Allow skins to style notification area

https://gerrit.wikimedia.org/r/205762

Krinkle mentioned this in rMW3f217db8e6c5: mediawiki.notification: Allow skins to style notification area.May 7 2015, 3:13 PM

Change 205763 merged by jenkins-bot:
Style mw.notify in the same way as toasts

https://gerrit.wikimedia.org/r/205763

Jdlrobson mentioned this in rEMFR57f26dba9658: Style mw.notify in the same way as toasts.May 11 2015, 5:38 PM

Diffusion mentioned this in rMEXT89428d5599b9: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 11 2015, 5:38 PM

Can this be closed as resolved @Jdlrobson?

I guess so. mw.notify or toast can be used with same effect now. We might want to merge the codebases in future though.

• Phabricator_maintenance moved this task from 2017-18 Q3 to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:18 AM