Page MenuHomePhabricator

Drop use of nth-child selector in ui.less
Closed, ResolvedPublic

Description

One of the important things to understand about how browsers read your CSS selectors, is that they read them from right to left.

This means the first thing that is read in the rule .header > *:nth-child(3) is :nth-child(3)

Looking closely at the performance issues documented in bug 64709 - a big cause of the lag is this selector. Removing it from ui.less improves performance to the same standard as the desktop site.


Version: unspecified
Severity: normal

Details

Reference
bz64719

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:23 AM
bzimport set Reference to bz64719.
bzimport added a subscriber: Unknown Object (MLST).
Jdlrobson created this task.May 1 2014, 9:43 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/wmlklDjZ

Change 131892 had a related patch set uploaded by Jdlrobson:
Cleanup ui.less now universal header

https://gerrit.wikimedia.org/r/131892

Change 131892 merged by jenkins-bot:
Fix VE performance by cleaning up ui.less now universal header

https://gerrit.wikimedia.org/r/131892