Page MenuHomePhabricator

VisualEditor: Transition between read mode and edit mode should have minimal visual shifts
Closed, ResolvedPublic

Description

Issues right now:

  • Different set of elements (e.g. #contentSub is shown in read mode, but not in edit mode. The same goes for TOC, though we do account for that one).
  • Different offset (the toolbar is injected which causes an abrupt visual shift).
  • Different scroll offset (same as before, but applies when you open the editor when scrolled down the page, after the transition, you're looking at a potentially very different part of the document, we should preserve it or jump to the top, not leave you somewhere randomly).

Version: unspecified
Severity: normal

Details

Reference
bz64751

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:26 AM
bzimport set Reference to bz64751.

Change 131071 had a related patch set uploaded by Krinkle:
ve.init.mw.ViewPageTarget: Actually animate the toolbar during setup

https://gerrit.wikimedia.org/r/131071

Change 131074 had a related patch set uploaded by Krinkle:
ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted

https://gerrit.wikimedia.org/r/131074

Change 131074 merged by jenkins-bot:
ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted

https://gerrit.wikimedia.org/r/131074

Change 131071 merged by jenkins-bot:
ve.init.mw.ViewPageTarget: Actually animate the toolbar during setup

https://gerrit.wikimedia.org/r/131071

Enough now that I'm going to call this done.