Page MenuHomePhabricator
Create Task
Maniphest T68369

Use rspec-expectations "expect" syntax instead of "should" syntax
Closed, DeclinedPublic
Actions

Description

For list of repositories see https://www.mediawiki.org/wiki/Repositories_with_Ruby_code

For more information see https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium#expect_or_should

Still not implemented in:

  • mediawiki/extensions/ArticleFeedbackv5
  • mediawiki/extensions/CirrusSearch
  • mediawiki/extensions/ContentTranslation
  • mediawiki/extensions/Flow
  • mediawiki/extensions/Gather
  • mediawiki/extensions/MultimediaViewer
  • mediawiki/extensions/PdfHandler
  • mediawiki/extensions/Translate
  • mediawiki/extensions/TwnMainPage
  • mediawiki/extensions/UniversalLanguageSelector
  • mediawiki/extensions/UploadWizard
$ grep --include *.rb  -R -F '.should' .

mediawiki/vagrant/mediawiki/extensions/ArticleFeedbackv5/tests/browser/features/step_definitions/aftv5_steps.rb:    page.yes_element.when_present.should be_visible
...
mediawiki/vagrant/mediawiki/extensions/CirrusSearch/tests/browser/features/step_definitions/page_steps.rb:    result.status.should eq 200
...
mediawiki/vagrant/mediawiki/extensions/ContentTranslation/tests/browser/features/step_definitions/basic_mt_steps.rb:  on(ContentTranslationPage).translation_editor_element.text.should == text
...
mediawiki/vagrant/mediawiki/extensions/Flow/tests/browser/features/step_definitions/description_steps.rb:    page.description.content.should eq(content)
...
mediawiki/vagrant/mediawiki/extensions/Gather/tests/browser/features/step_definitions/recent_collections_steps.rb:  on(GatherRecentPage).collection_one_hundred_element.should exist
...
mediawiki/vagrant/mediawiki/extensions/MultimediaViewer/tests/browser/features/step_definitions/mmv_options_steps.rb:  on(E2ETestPage).mmv_options_menu_disable_element.should be_visible
...
mediawiki/vagrant/mediawiki/extensions/PdfHandler/tests/browser/features/step_definitions/pdf_steps.rb:  on(PdfPage).download_as_pdf_element.should exist
...
mediawiki/vagrant/mediawiki/extensions/Translate/tests/browser/features/step_definitions/manage_translator_sandbox_steps.rb:	on(UserPage).babel_box_has_languages?(languages).should be_true
...
mediawiki/vagrant/mediawiki/extensions/TwnMainPage/tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb:		page.number_of_translators_element.should be_visible
...
mediawiki/vagrant/mediawiki/extensions/UniversalLanguageSelector/tests/browser/features/step_definitions/accept_language_steps.rb:  on(MainPage).main_page_element.text.should == text
...
mediawiki/vagrant/mediawiki/extensions/UploadWizard/tests/browser/features/step_definitions/chunked_upload_steps.rb:  on(UploadPage).continue_element.when_present(300).should be_visible
...

Details

Reference
bz66369
SubjectRepoBranchLines +/-
Use rspec-expectations "expect" syntax instead of "should" syntaxmediawiki/coremaster+64 -64
Change RSpec 2 should syntax to RSpec 3 expect syntaxmediawiki/extensions/PageTriagemaster+12 -6
RSpec 3 expect syntax incorporationmediawiki/extensions/WikiLovemaster+5 -5
Refactor code for RSpec3 expect syntax incorporationmediawiki/extensions/Mathmaster+5 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:11 AM
• bzimport added a project: Quality-Assurance.
• bzimport set Reference to bz66369.
zeljkofilipin created this task.Jun 9 2014, 1:39 PM
zeljkofilipin added a comment.Jun 9 2014, 1:50 PM
This comment was removed by zeljkofilipin.
Jagori79 added a comment.Jun 12 2014, 8:47 AM

@Zeljko: I am not able to assign the bug to myself.Could you please look into it.
I cannot see the "Edit" link.

Jagori79 added a comment.Jun 14 2014, 1:23 PM

(In reply to Željko Filipin from comment #1)

Pick a repository:

https://github.com/wikimedia/mediawiki-selenium#links

Replace all expect syntax with should syntax.

Editing the above line to :
 > Replace all should syntax with expect syntax.
gerritbot added a comment.Jul 16 2014, 8:06 AM

Change 146712 had a related patch set uploaded by Jagori79:
WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax

https://gerrit.wikimedia.org/r/146712

gerritbot added a comment.Jul 18 2014, 12:16 PM

Change 147423 had a related patch set uploaded by Zfilipin:
Use rspec-expectations expect syntax instead of should syntax

https://gerrit.wikimedia.org/r/147423

gerritbot added a comment.Jul 18 2014, 3:12 PM

Change 147423 merged by jenkins-bot:
Use rspec-expectations expect syntax instead of should syntax

https://gerrit.wikimedia.org/r/147423

gerritbot added a comment.Nov 4 2014, 10:46 AM

Change 146712 abandoned by Zfilipin:
WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax

Reason:
No activity on the commit in months. Please restore if you plan to work on this.

https://gerrit.wikimedia.org/r/146712

gerritbot added a comment.Nov 25 2014, 9:22 AM

Change 146712 restored by Jagori79:
WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax

Reason:
Restoring

https://gerrit.wikimedia.org/r/146712

Jagori79 added a comment.Nov 25 2014, 9:34 AM

Zeljko:I see the changes already implemented for Visual editor code,should I abandon the part which I was working on :https://gerrit.wikimedia.org/r/#/c/146712/

I had restored it .

zeljkofilipin added a comment.Nov 26 2014, 9:48 AM

If the change you were working on is already implemented, it probably makes sense to abandon your commit. We have plenty of other repositories where the change should be implemented. :)

https://github.com/wikimedia/mediawiki-selenium#links

Jagori79 added a comment.Nov 27 2014, 12:31 PM

Thanks,Yes,will work on the other repositories.

gerritbot added a comment.Dec 4 2014, 1:15 AM

Change 146712 abandoned by Jagori79:
WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax

Reason:
I am abandoning this change as already been implemented for Visual Editor.I will make the expect syntax changes on other codebase as suggested by Chris on the QA mailing list.

https://gerrit.wikimedia.org/r/146712

gerritbot added a project: Patch-For-Review.Dec 11 2014, 7:10 AM

Change 179072 had a related patch set uploaded (by Physikerwelt):
Refactor code for RSpec3 expect syntax incorporation

https://gerrit.wikimedia.org/r/179072

Patch-For-Review

Physikerwelt subscribed.Jan 24 2015, 10:19 AM

@Cmcmahon can you do a code review for this change?

gerritbot subscribed.Jan 27 2015, 11:56 AM

Change 186947 had a related patch set uploaded (by Jagori79):
RSpec3 expect syntax incorporation

https://gerrit.wikimedia.org/r/186947

Patch-For-Review

gerritbot added a comment.Jan 27 2015, 12:12 PM

Change 186947 had a related patch set uploaded (by Jagori79):
RSpec3 expect syntax incorporation

https://gerrit.wikimedia.org/r/186947

Patch-For-Review

gerritbot added a comment.Jan 27 2015, 12:37 PM

Change 186949 had a related patch set uploaded (by Jagori79):
Changing should to expect syntax

https://gerrit.wikimedia.org/r/186949

Patch-For-Review

gerritbot added a comment.Jan 28 2015, 11:04 PM

Change 187269 had a related patch set uploaded (by Jagori79):
RSpec3 expect syntax incorporation

https://gerrit.wikimedia.org/r/187269

Patch-For-Review

Physikerwelt added a comment.Jan 29 2015, 9:45 AM

I was not able to test this for the Math Extension:
See my comment in gerrit:
"
I could not test the effects of this change. I tried to run the tests on labs-vagrant instance following the guide at https://www.mediawiki.org/w/index.php?title=Quality_Assurance/Browser_testing/Running_tests#Running_VisualEditor_browser_tests_via_labs-vagrant However, even on master I get the following output https://gist.github.com/physikerwelt/5761056c077c02a8c636
"

Physikerwelt added a project: Math.Feb 7 2015, 8:36 PM
Physikerwelt set Security to None.
gerritbot added a comment.Feb 16 2015, 7:46 PM

Change 179072 merged by jenkins-bot:
Refactor code for RSpec3 expect syntax incorporation

https://gerrit.wikimedia.org/r/179072

Physikerwelt closed this task as Resolved.Feb 16 2015, 7:47 PM
Physikerwelt mentioned this in rEMAT197bd9ccd6d4: Refactor code for RSpec3 expect syntax incorporation.Feb 16 2015, 7:53 PM
gerritbot added a comment.Feb 21 2015, 11:02 AM

Change 187269 merged by jenkins-bot:
RSpec 3 expect syntax incorporation

https://gerrit.wikimedia.org/r/187269

zeljkofilipin mentioned this in rEWLO95e7c6cf9e76: RSpec 3 expect syntax incorporation.Feb 21 2015, 11:04 AM
gerritbot added a comment.Feb 21 2015, 11:11 AM

Change 186949 merged by jenkins-bot:
Change RSpec 2 should syntax to RSpec 3 expect syntax

https://gerrit.wikimedia.org/r/186949

zeljkofilipin mentioned this in rEPTR1d532b0c83d0: Change RSpec 2 should syntax to RSpec 3 expect syntax.Feb 21 2015, 11:13 AM
Diffusion mentioned this in rMEXTfe31f91fd9d7: Updated mediawiki/extensions Project: mediawiki/extensions/Math….Mar 11 2015, 6:26 AM
Jagori79 mentioned this in rMEXT3a9484881b0a: Updated mediawiki/extensions Project: mediawiki/extensions/WikiLove….Mar 11 2015, 6:27 AM
Diffusion mentioned this in rMEXT4511bad823f1: Updated mediawiki/extensions Project: mediawiki/extensions/PageTriage….Mar 11 2015, 6:27 AM
zeljkofilipin renamed this task from use rspec-expectations expect syntax instead of should syntax to Use rspec-expectations "expect" syntax instead of "should" syntax.Mar 20 2015, 1:22 PM
zeljkofilipin reopened this task as Open.
zeljkofilipin added a comment.Mar 20 2015, 1:34 PM
This comment was removed by zeljkofilipin.
zeljkofilipin added a subscriber: Amire80.Mar 20 2015, 1:34 PM
gerritbot added a comment.Mar 20 2015, 2:23 PM

Change 186947 merged by jenkins-bot:
Use rspec-expectations "expect" syntax instead of "should" syntax

https://gerrit.wikimedia.org/r/186947

Physikerwelt added a comment.Mar 20 2015, 2:49 PM

Sorry for closing this bug. I thought it was only about the Math extension, because the project Math was specified. I think in the future it might be better to add subtasks for each extension.

zeljkofilipin added a project: Release-Engineering-Team.Mar 20 2015, 2:59 PM

@Physikerwelt: no problem. I think it would be a lot of noise if we created 20 or so subtasks, but it is something to consider for the future tasks.

zeljkofilipin mentioned this in rMWd9ba5ad12194: Use rspec-expectations "expect" syntax instead of "should" syntax.Mar 23 2015, 3:51 PM
zeljkofilipin edited projects, added Browser-Tests-Infrastructure; removed Quality-Assurance.Mar 25 2015, 1:54 PM

@Jagori79 are you working on this? If not, please remove yourself from "assigned to". Thanks.

Jagori79 removed Jagori79 as the assignee of this task.Mar 30 2015, 11:17 AM

Removed

Physikerwelt removed a project: Math.Apr 24 2015, 8:43 PM
zeljkofilipin moved this task from Inbox to In Progress on the Browser-Tests-Infrastructure board.Jul 3 2015, 1:25 PM
zeljkofilipin removed projects: Release-Engineering-Team, Patch-For-Review.Jul 7 2015, 3:41 PM

Removed release-engineering, since it does not belong there.
Removed patch-for-review, since all related patches (as far as I can see) are merged or abandoned.

zeljkofilipin moved this task from In Progress to Next on the Browser-Tests-Infrastructure board.Jul 7 2015, 3:43 PM
zeljkofilipin moved this task from Next to Ruby on the Browser-Tests-Infrastructure board.Sep 30 2015, 1:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2015, 1:24 PM
zeljkofilipin claimed this task.Sep 30 2015, 2:00 PM
zeljkofilipin moved this task from Ruby to In Progress on the Browser-Tests-Infrastructure board.
zeljkofilipin added a project: good first task.Sep 30 2015, 2:22 PM
zeljkofilipin moved this task from In Progress to Next on the Browser-Tests-Infrastructure board.Sep 30 2015, 2:59 PM
zeljkofilipin updated the task description. (Show Details)Sep 30 2015, 7:10 PM
zeljkofilipin removed a subscriber: • Cmcmahon.
zeljkofilipin updated the task description. (Show Details)Sep 30 2015, 7:12 PM
zeljkofilipin updated the task description. (Show Details)Sep 30 2015, 8:30 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin removed zeljkofilipin as the assignee of this task.Sep 30 2015, 8:32 PM
zeljkofilipin added a project: Tracking-Neverending.
zeljkofilipin moved this task from Next to Ruby on the Browser-Tests-Infrastructure board.
zeljkofilipin updated the task description. (Show Details)Oct 1 2015, 9:11 AM
zeljkofilipin added a comment.Nov 5 2015, 10:44 AM

A tool like these could automate the process:

http://xinminlabs.github.io/synvert/rules/
https://github.com/yujinakayama/transpec

Danny_B removed a project: Tracking-Neverending.Jul 20 2016, 1:07 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 20 2016, 1:07 AM
greg added a project: Release-Engineering-Team (Backlog).May 20 2017, 4:39 PM
zeljkofilipin closed this task as Declined.May 26 2017, 3:05 PM

Because of T139740: Port Selenium tests from Ruby to Node.js this is unlikely to ever get done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits