Maniphest T68512

Echo: Leading colon in user/user talk page links prevents signature from being detected
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	TTO
	Jun 12 2014, 1:06 AM

Tags

Referenced Files

None

Subscribers

• Mattflaschen-WMF

• wikibugs-l-list

Description

This edit [1] did not trigger a mention, seemingly because the user's signature contains a leading colon in the links:

-'''[[:User:K6ka|k6ka]]''' ([[:User_talk:K6ka#|talk]] &#124;
[[:Special:Contributions/K6ka|contribs]]) 11:37, 11 June 2014 (UTC)

[1] https://en.wikipedia.org/w/index.php?title=User_talk:K6ka&diff=612485855&oldid=612485595

Version: master
Severity: normal

Details

Reference: bz66512

Related Objects

Mentioned In: rMEXTc71c6b6574d6: Updated mediawiki/extensions Project: mediawiki/extensions/Echo…
rECHO3a1883f3db40: Add test case to demonstrate T68512 is fixed
rECHO95a6f459c53e: Merge "Add test case to demonstrate T68512 is fixed"
Mentioned Here: rECHO58e1c765d63f: Improve signature detection

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:21 AM

• bzimport added a project: Notifications.

• bzimport set Reference to bz66512.

• bzimport added a subscriber: Unknown Object (MLST).

TTO created this task.Jun 12 2014, 1:06 AM

• werdna unsubscribed.Dec 10 2014, 5:03 PM

Well, this just needs a :? at the start of the respective regular expression in https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FEcho/d53857c7c3fdca459bca8f343f2805691bdc94ba/includes%2FDiscussionParser.php#L678

• Mattflaschen-WMF triaged this task as Low priority.Feb 2 2015, 6:45 PM

• Mattflaschen-WMF subscribed.

Legoktm moved this task from Backlog to Needs code on the Notifications board.Jul 6 2015, 8:20 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 6 2015, 8:20 AM

This was fixed by rECHO58e1c765d63f: Improve signature detection.

Legoktm reassigned this task from Legoktm to matthiasmullie.Jul 7 2015, 12:30 AM

Legoktm set Security to None.

Change 223212 had a related patch set uploaded (by Legoktm):
Add test case to demonstrate T68512 is fixed

https://gerrit.wikimedia.org/r/223212

gerritbot added a project: Patch-For-Review.Jul 7 2015, 12:31 AM

Change 223212 merged by jenkins-bot:
Add test case to demonstrate T68512 is fixed

https://gerrit.wikimedia.org/r/223212

Diffusion mentioned this in rECHO95a6f459c53e: Merge "Add test case to demonstrate T68512 is fixed".Jul 7 2015, 7:18 PM

Legoktm mentioned this in rECHO3a1883f3db40: Add test case to demonstrate T68512 is fixed.Jul 7 2015, 7:18 PM

Diffusion mentioned this in rMEXTc71c6b6574d6: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Jul 7 2015, 7:19 PM

• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jul 8 2015, 11:54 PM