Page MenuHomePhabricator

UploadWizard: Flickr blacklist API changed somehow
Closed, ResolvedPublic

Description

Running tests for UploadWizard, the Flickr blacklist test no more works:

amusso@aeriale:/srv/trunk/tests/phpunit(masteru=)$ php phpunit.php --testsuite extensions
PHPUnit 3.7.30 by Sebastian Bergmann.

Configuration read from /Users/amusso/projects/mediawiki/core/tests/phpunit/suite.xml

FFF.................

Time: 6.26 seconds, Memory: 37.00Mb

There were 3 failures:

  1. ApiFlickrBlacklistTest::testBlacklistMatchByNsid

blacklist does not match
Failed asserting that two strings are equal.

  • Expected

+++ Actual
@@ @@
-'bad'
+'ok'

/Users/amusso/projects/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:193
/Users/amusso/projects/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:52
/Users/amusso/projects/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/Users/amusso/projects/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42

  1. ApiFlickrBlacklistTest::testBlacklistMatchByUsername

blacklist does not match
Failed asserting that two strings are equal.

  • Expected

+++ Actual
@@ @@
-'bad'
+'ok'

/Users/amusso/projects/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:193
/Users/amusso/projects/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:70
/Users/amusso/projects/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/Users/amusso/projects/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42

  1. ApiFlickrBlacklistTest::testBlacklistMatchWithMultipleItems

blacklist does not match
Failed asserting that two strings are equal.

  • Expected

+++ Actual
@@ @@
-'bad'
+'ok'

/Users/amusso/projects/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:193
/Users/amusso/projects/mediawiki/extensions/UploadWizard/tests/phpunit/ApiFlickrBlacklistTest.php:82
/Users/amusso/projects/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:133
/Users/amusso/projects/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:42

FAILURES!
Tests: 20, Assertions: 38, Failures: 3.
amusso@aeriale:/srv/trunk/tests/phpunit(masteru=)$

Change occurred after June 24th and before July 4th.


Version: unspecified
Severity: normal

Details

Reference
bz67584

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:38 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz67584.
hashar created this task.Jul 7 2014, 9:59 AM

Change 144448 had a related patch set uploaded by Gilles:
Point to HTTPS URL for Flickr API

https://gerrit.wikimedia.org/r/144448

  • This bug has been marked as a duplicate of bug 67298 ***

[Backport to servers was not done in July, hence setting Backport_WMF flag to -]

Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 9:30 AM