Page MenuHomePhabricator

VisualEditor: Consider whether exiting the link dialog in create mode should remove the link
Closed, ResolvedPublic


Author: ronnirubin

Re bug 68101

Load VE. Say "Foobar" is the first word on the page.
If you click on the link tool, by mistake or not, without selecting anything before, Foobar will automatically become a link to the Foobar page (it doesn't help that pressing ESC doesn't abort the action, the link gets applied anyway, as we know).

ESC _should not_ exit and save; it should either exit without saving, or revert the change (in this case, the link) without exiting. I was going to set the Severity to "blocker", as it would block installation on en.Wikipedia, but that would be wrong.

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:39 AM
bzimport set Reference to bz69407.

This is a mistaken understanding of what the button does, and what the window is for.

  • The link button *creates* a link if there is none there already.
  • Once the link is created, we then also pop up a link editing window
  • This is to let you change the link to point to a different place, or remove it.
  • Pressing escape closes the editing window, leaving you with the link you created.

This is intentional design. Escape isn't "applying" anything, but it's probably not very clear. Maybe design would like to comment?

Unfortunately I agree with BOTH of you.
I am often confused by the behaviour of the link dialogue and am often looking for the "insert" or "confirm" button. "Done" doesn't seem right to me somehow.
On the other hand, James is right too. The behaviour of all the formatting icons on the toolbar is that as soon you press them, the action takes place. So, highlighting a word and pressing "bold" will cause the text to go bold immediately, not after a second 'confirmation click'.
Nevertheless, despite intellectually understanding the link dialogue design, I keep stumbling on it - it gets in the way and I have to consciously think about it - which is not good behaviour for a labor-saving device.

Not sure if I'm adding further confusion :)
(and I think this task didn't keep T101176 into account?)
but from what I'm reading at the German Wikipedia,
some would find it desirable that ESC allowed to leave the "blue" link area after a link is added and placed the cursor just at the right so that people can quickly start typing again.

Currently, hitting ESC right after choosing a link target doesn't close the link tool - it prompts the "Are you sure?" dialog to leave the page entirely.
Also, to get out of the blue area just via the keyboard, you need to hit the right arrow twice (which doesn't seem much intuitive).

Esanders claimed this task.
Esanders added a subscriber: Esanders.

This was fixed a while ago.