Delete button on the page http://localhost:8080/wiki/Headings?action=delete is green.
Expected:
It should be red.
Also the input field is tiny. It should be larger.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz70134
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | • Mattflaschen-WMF | T99211 Eliminate $wgUseMediaWikiUIEverywhere, leaving 'on' behavior | |||
| Declined | • Mattflaschen-WMF | T72424 Set $wgUseMediaWikiUIEverywhere = true | |||
| Declined | None | T72913 Remove $wgUseMediaWikiUIEverywhere dependency for button and text input styling | |||
| Resolved | None | T72134 Deletion page has mw-ui-constructive button, Other/additional reason input is tiny |
Event Timeline
Comment Actions
Only admins can see this page, can you add a screenshot?
But yes probably primary destructive If that's the main action on the page.
Comment Actions
we can break it into separate bugs if we like, but might want to update all the controls (that already exist) at the same time.
Comment Actions
Change 154121 had a related patch set uploaded by Jdlrobson:
Fix styling of deletion page
Comment Actions
(In reply to Jared Zimmerman (WMF) from comment #7)
we can break it into separate bugs if we like, but might want to update all
the controls (that already exist) at the same time.
Actually, it does use the controls that are already implemented. The reason it looks inconsistent in that screenshot is that it's using the MW UI button even when wgUseMediaWikiUIEverywhere is false (that screenshot was taken with it false).
When that's fixed, we can do a new screenshot with wgUseMediaWikiUIEverywhere set to true.
Comment Actions
Created attachment 16423
Deletion page with wgUseMediaWikiUIEverywhere true
I've attached a screenshot (with the global on) of the latest version.
In my opinion, it's still too short.
Attached:
Comment Actions
Can we merge the existing patch and then raise a new bug to discuss the correct input size? Surely the use of the destructive button is a useful bit of progress? :)
Comment Actions
I didn't -1 it, and I don't know if I can review it today regardless, but please at least tag it with the bug.
Comment Actions
gerritadmin wrote:
Change 154121 had a related patch set uploaded by Jdlrobson:
Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled
Comment Actions
gerritadmin wrote:
Change 154121 merged by jenkins-bot:
Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled