Page MenuHomePhabricator

Deletion page has mw-ui-constructive button, Other/additional reason input is tiny
Closed, ResolvedPublic

Description

Delete button on the page http://localhost:8080/wiki/Headings?action=delete is green.

Expected:
It should be red.

Also the input field is tiny. It should be larger.


Version: unspecified
Severity: normal

Details

Reference
bz70134

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:33 AM
bzimport set Reference to bz70134.
bzimport added a subscriber: Unknown Object (MLST).

Only admins can see this page, can you add a screenshot?

But yes probably primary destructive If that's the main action on the page.

Created attachment 16361
before

Attached:

Created attachment 16362
after

Attached:

Should the delete button be aligned to the right too?

Created attachment 16363
v2

Attached:

we can break it into separate bugs if we like, but might want to update all the controls (that already exist) at the same time.

  • Bug 70135 has been marked as a duplicate of this bug. ***

Change 154121 had a related patch set uploaded by Jdlrobson:
Fix styling of deletion page

https://gerrit.wikimedia.org/r/154121

(In reply to Jared Zimmerman (WMF) from comment #7)

we can break it into separate bugs if we like, but might want to update all
the controls (that already exist) at the same time.

Actually, it does use the controls that are already implemented. The reason it looks inconsistent in that screenshot is that it's using the MW UI button even when wgUseMediaWikiUIEverywhere is false (that screenshot was taken with it false).

When that's fixed, we can do a new screenshot with wgUseMediaWikiUIEverywhere set to true.

Created attachment 16423
Deletion page with wgUseMediaWikiUIEverywhere true

I've attached a screenshot (with the global on) of the latest version.

In my opinion, it's still too short.

Attached:

Can we merge the existing patch and then raise a new bug to discuss the correct input size? Surely the use of the destructive button is a useful bit of progress? :)

I didn't -1 it, and I don't know if I can review it today regardless, but please at least tag it with the bug.

gerritadmin wrote:

Change 154121 had a related patch set uploaded by Jdlrobson:
Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled

https://gerrit.wikimedia.org/r/154121

gerritadmin wrote:

Change 154121 merged by jenkins-bot:
Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled

https://gerrit.wikimedia.org/r/154121