Page MenuHomePhabricator

VisualEditor: In template dialog, the “show one more field” control appears when there are 4 entries
Closed, ResolvedPublic

Description

screenshot1

Environment- test2, beta, production

1> open a page in VE, add a template. Add a Field name to the template, now delete that name.
2>click to add more information again, notice the previous field name entry is shown in a list.
3> In the same Field name, type in another name , now delete that name.
4> Repeat steps #2 and 3. Until you get the show one more field(this appears after the 4th entry). Click on it and it seems to add nothing to the existing Template data.
Same behavior can be seen with Templates having at least 4 parameters, for ex- Reflist.
See screenshots.


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz70609

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz70609.
Swainr created this task.Sep 9 2014, 3:15 PM
Swainr added a comment.Sep 9 2014, 3:16 PM

Created attachment 16415
screenshot2

Attached:

gerritadmin wrote:

Change 160500 had a related patch set uploaded by Jforrester:
Template dialog: Show up to the limit of parameters, not up to the limit + 1

https://gerrit.wikimedia.org/r/160500

gerritadmin wrote:

Change 160500 merged by jenkins-bot:
Template dialog: Show up to the limit of parameters, not up to the limit + 1

https://gerrit.wikimedia.org/r/160500

Swainr added a comment.Oct 6 2014, 3:22 PM

Issue fixed in test2, beta, production.