Page MenuHomePhabricator

2.0 Figure out how gadget naming collisions should work, and document it
Closed, DeclinedPublic

Description

From https://www.mediawiki.org/wiki/ResourceLoader/V2_Task_management:

(RK) Figure out how gadget ID naming collisions should be handled, define this somewhere, and enforce it


I think local gadgets should take precedence, and then give precedence to whatever shared repo is first in $wgGadgetRepositories.


Version: unspecified
Severity: normal

Details

Reference
bz70824

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:42 AM
bzimport set Reference to bz70824.
bzimport added a subscriber: Unknown Object (MLST).

Hmm, something else I thought of. Right now if a user enables a gadget "foo", and a repo higher up in the precedence chain creates a gadget named "foo" as well, the user will now get the JS/CSS from the new repo instead of what they actually enabled. If we make the local repo highest priority, a local gadget-manager could override popular global gadgets in this form to hypothetically compromise accounts. Or something not so good.

Possible solution: Embed the repo name in the preference key, so that if the source of a gadget changes, the user won't keep the same preference value. Might be a bit confusing from a UX perspective.

Legoktm claimed this task.

Gadgets 2.0 is no longer implementing global gadgets.