Page MenuHomePhabricator

VisualEditor: [Regression wmf1] Template parameter autovalues are not saved
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert the template "Citation needed"
3.Observe that in the field for "Month and year", the following has been used:
{{subst:CURRENTMONTHNAME}} {{subst:CURRENTYEAR}}
4.Now click on "Apply Changes"
5.Save the page
6.Reopen the page
7.Open the transclusion dialog for the "Citation Needed" template

Observed Result:
The current month name and current year value did not get added in the field.

Environment:Betalabs


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz71157

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:47 AM
bzimport set Reference to bz71157.

Definitely VE's fault. We're somehow not sending the parameter value to Parsoid when saving.

Change 168204 had a related patch set uploaded by Catrope:
Actually set parameter autoValues as values

https://gerrit.wikimedia.org/r/168204

Change 168205 had a related patch set uploaded by Catrope:
Apply pre-save transform to template previews

https://gerrit.wikimedia.org/r/168205

Change 168204 merged by jenkins-bot:
Actually set parameter autoValues as values

https://gerrit.wikimedia.org/r/168204

Change 168205 merged by jenkins-bot:
Apply pre-save transform to template previews

https://gerrit.wikimedia.org/r/168205

Verified in betalabs.

This seem to be not working in production (en.wiki).I dont even see the substitute values {{subst:CURRENTMONTHNAME}} {{subst:CURRENTYEAR}} for the parameters.

(In reply to Rummana Yasmeen from comment #7)

This seem to be not working in production (en.wiki).I dont even see the
substitute values {{subst:CURRENTMONTHNAME}} {{subst:CURRENTYEAR}} for the
parameters.

This seems to be because the Citation needed template on enwiki doesn't have the autovalue set up yet. James said he would do this, but he was waiting for this bug to be fixed.