| Jdlrobson | |
| Sep 23 2014, 4:45 PM |
| F39200: Applying_simultaneous_mediawiki.ui_and_oojs-ui_styles | |
| Feb 11 2015, 3:41 AM |
Various projects are making use of icons. Let's all use the same markup as documented here [1] and upstream the common icon classes into some kind of sharing library.
By using the markup we can also make improvements to the CSS for all MediaWiki based projects.
[1] http://tools.wmflabs.org/styleguide/desktop/section-4.html
Version: unspecified
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | • Mattflaschen-WMF | T73180 Use mw-ui-icon (tracking) | |||
| Resolved | Jdlrobson | T73181 [Tracking] MobileFrontend should use mw-ui-icon | |||
| Invalid | None | T74653 Issues with icons in alpha. Get fixed so we can move it to beta. | |||
| Declined | • Mattflaschen-WMF | T73182 Migrate Flow to use mediawiki ui icons markup | |||
| Declined | • Mattflaschen-WMF | T73184 GuidedTour: Use .mw-ui-icon where possible |
Where's this at, is it still something we're pursuing? MobileFrontend has 21 mw-ui-icon- CSS classes, but mediawiki.UI in core only has one, mw-ui-icon-ok.
Meanwhile
.oo-ui-image-destructive.oo-ui-icon-remove {
background-image: url("themes/mediawiki/images/icons/remove-destructive.svg");
}and also generates the png variants.
Maybe we can make the latter piece of the OOjs UI mediawiki theme available to mediawiki.UI clients. I tried loading 'oojs-ui.styles' and combining its classes with 'mediawiki.ui.button', but OOjs UI has a more elaborate div structure.
Doubtful. I think the medium-term vision is OOJS-UI for this.
- RL in core now has an undocumented ResourceLoaderImageModule class which knows about SVG icons and can provide a rasterized version as a fallback (from demo, ?modules=oojs-ui-test&image=next&format=rasterized), but I don't think anything uses it.
MobileFrontend at least is.
I'm interested in exploring replacing mw-ui-icon in MobileFrontend with oo js ui - the only place we currently use it is in beta.
We're deprecating MW UI (T100270), so we shouldn't be moving to use it more. Projects will move to OOjs UI icons in the course of broader migrations (e.g. when adopting a modal or toolbar); probably doesn't require a separate bug just for that part.