Page MenuHomePhabricator

Audio tags shouldn't have height. Look cramped in mobile.
Closed, ResolvedPublic

Description

this problem features on many song articles

I'm not sure what creates the audio tags - core or an extension but they shouldn't be styled with fix widths and heights.

expected: it should do it in a stylesheet if necessary for Vector.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz71365

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz71365.

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/VZh3nH2X

phuedx added a comment.Oct 8 2014, 1:57 PM

The audio tags are created by the TimedMediaTransformOutput class in the TimedMediaHandler extension.

The TimedMediaTransformOutput can create tags for both audio and video elements. My approach will be to remove the inline styling for /audio tags only/ and then create a follow-on bug for dealing with the video tags.

brion added a comment.Oct 8 2014, 2:00 PM

See also bug 61823 (ogv.js player integration) -- the last patchset on it adds a mobile media player overlay for audio and video, using ogv.js on Safari or the native <audio>/<video> elements if supported.

However it's bitrotted in the last few weeks and needs updating for current MobileFrontend/Mantle.

Change 165753 had a related patch set uploaded by Phuedx:
Don't give audio tags a height style

https://gerrit.wikimedia.org/r/165753

Change 165753 merged by jenkins-bot:
Don't give audio tags a height style

https://gerrit.wikimedia.org/r/165753